WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #22058, comment 37


Ignore:
Timestamp:
07/30/2016 04:07:59 PM (5 years ago)
Author:
afercia
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #22058, comment 37

    initial v1  
    1515- proper fieldsets and legends would also allow to simplify the labels: no need to repeat "Set Tile Background to...", "Set Tile Background to...", "Set Tile Background to..." etc. for each option
    1616- selected state: if radio buttons, that's natively announced by assistive technologies but if `<buttons>` then they would need an `aria-pressed` attribute, as done for the "device preview" buttons
    17 - initial state: not clear why some properties have a clear indication of the initial state and others don't, see also the `false` value set for these properties in the screenshot below
     17- initial state (edit: I meant initial default value): not clear why some properties have a clear indication of the initial value and others don't, see also the `false` value set for these properties in the screenshot below
    1818- technical terminology: completely agree to avoid it, I'd also add that some terms are difficult to translate, for example "tile" and maybe the wording should just explain users what a control does with the simplest possible wording
    1919