WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #22058, comment 79


Ignore:
Timestamp:
10/05/2016 03:41:34 PM (4 years ago)
Author:
cdog
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #22058, comment 79

    initial v1  
    11Before updating the patch I've added two new images.
    22
    3 @celloexpressions Any reasons not to keep the vertical position options? The [https://developer.mozilla.org/en-US/docs/Web/CSS/background-position background-position] property was defined in [https://www.w3.org/TR/CSS1/#background-position CSS Level 1] and is fully supported even by legacy browsers like older versions of IE. Removing it was suggested before, although this is how the ticket started.
     3@celloexpressions Any reasons not to keep the vertical position options? The [https://developer.mozilla.org/en-US/docs/Web/CSS/background-position background-position] property was defined in [https://www.w3.org/TR/CSS1/#background-position CSS Level 1] and is fully supported even by legacy browsers like older versions of IE. Removing it was suggested before, although this is how the ticket started. Can someone elaborate on this?
    44
    55@melchoyce, @jorbin I completely agree with you. How to simplify, do you have any suggestions?
     
    77[attachment:22058-variations.png] shows three variations based on the feedback received so far. Can we pick one of them to go with the patch or there is room for more improvements? Personally I'd stick with option 3. @helen what's your opinion on this?
    88
    9 [attachment:22058-options.png] shows a possible implementation (similar with the Menus section from Customizer) of how we can toggle the background options visibility. This should work with any of the above variations.
     9[attachment:22058-options.png] shows a possible implementation (similar with the Menus section from Customizer) of how we can toggle the background options visibility. This should work with any of the above variations. Hiding all options would leave visible only the image and presets.
    1010
    1111Again, any feedback on this is kindly appreciated. Thank you!