WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #22101, comment 11


Ignore:
Timestamp:
09/27/2017 11:36:24 PM (3 years ago)
Author:
birgire
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #22101, comment 11

    initial v1  
    33As unrelated, I noticed that the test in {{{test_wp_get_attachment_image_should_use_wp_get_attachment_metadata()}}} can only run once, because the filename gets an increasing index, like {{{test-image-large-{$i}-150x150.png}}} in the srcset, where {{{$i > 2}}} is the number of times we run the {{{/tests/phpunit/tests/media.php}}} tests. Looks like we might need a better cleanup there?
    44
    5 I tried to avoid this in the above test by not referring to the exact filename.
     5I tried to avoid this in the above test by not referring to the exact filename for {{{self::$large_id}}}, as it would also get the same increasing index for repeated test runs.
    66