WordPress.org

Make WordPress Core

#22107 closed defect (bug) (fixed)

user_email_used error string is not used anywhere?

Reported by: pavelevap Owned by: SergeyBiryukov
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.0
Component: Multisite Keywords: has-patch commit 3.6-early
Focuses: Cc:

Description

During localization I found a string that I could not see anywhere. I could reproduce it only in one situation and that does not make sense (string should not be displayed in this case). Maybe we could remove the whole string and related logic because is obsolete and never used? See attached patch.

Or if I am missing something, this string should be at least improved a little (capital letter).

Attachments (3)

user_email_used.patch (1.2 KB) - added by pavelevap 19 months ago.
22107.patch (1.2 KB) - added by SergeyBiryukov 18 months ago.
Refreshed to remove an empty line
22107.2.patch (1.8 KB) - added by SergeyBiryukov 15 months ago.

Download all attachments as: .zip

Change History (13)

comment:1 SergeyBiryukov19 months ago

  • Component changed from General to Multisite
  • Keywords has-patch added
  • Version changed from trunk to 3.0

Introduced in mu:825. Doesn't seem to be used or displayed anywhere.

show_user_form() only displays get_error_message('user_email'), which is set in the next block:
http://core.trac.wordpress.org/browser/tags/3.4.2/wp-includes/ms-functions.php#L507
http://core.trac.wordpress.org/browser/tags/3.4.2/wp-signup.php#L134

Last edited 19 months ago by SergeyBiryukov (previous) (diff)

comment:2 SergeyBiryukov18 months ago

  • Milestone changed from Awaiting Review to 3.5

comment:3 wpmuguru18 months ago

patch looks good.

SergeyBiryukov18 months ago

Refreshed to remove an empty line

comment:4 SergeyBiryukov18 months ago

  • Keywords commit added

comment:5 nacin18 months ago

  • Keywords 3.6-early added
  • Milestone changed from 3.5 to Future Release

comment:6 SergeyBiryukov16 months ago

  • Milestone changed from Future Release to 3.6

SergeyBiryukov15 months ago

comment:7 follow-ups: SergeyBiryukov15 months ago

Found one more piece of dead code:
http://core.trac.wordpress.org/browser/tags/3.5.1/wp-signup.php#L139

We don't use 'generic' error code anywhere in core. If a plugin wants to display a custom error message there, signup_extra_fields action can be used for that.

comment:8 in reply to: ↑ 7 SergeyBiryukov15 months ago

Replying to SergeyBiryukov:

Found one more piece of dead code

Introduced in mu:543 along with the file itself.

comment:10 SergeyBiryukov14 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 23412:

Remove unused error string. props pavelevap. fixes #22107.

Note: See TracTickets for help on using tickets.