Make WordPress Core

Opened 3 years ago

Last modified 3 months ago

#22150 new defect (bug)

Customizer: Remove Image doesn't remove from Media Library

Reported by: pento Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 3.4
Component: Upload Keywords: needs-patch
Focuses: Cc:


After uploading an image using the Theme Customizer, a "Remove Image" link appears - this seems to imply that clicking it will cause the image to be deleted entirely, rather than just hidden from the current view.

Change History (5)

#1 follow-up: @nacin
3 years ago

It is designed to only remove the header image, not the underlying upload.

But: uploads should be disabled in trunk. What dark voodoo is this?

#2 @pento
3 years ago

The wording could probably be better. For me, at least, I assumed it was going to remove from the Media Library.

You just made me svn info and svn up to be sure. I'm definitely testing on trunk HEAD, with Twenty Eleven. I see a shiny upload box for me to drag and drop things on to.

#3 in reply to: ↑ 1 @SergeyBiryukov
3 years ago

Replying to nacin:

But: uploads should be disabled in trunk.

For header images (#21355), but not for custom background.

#4 @nacin
3 years ago

  • Version changed from trunk to 3.4

I'm happy to improve the string, but I don't see much room for improvement. We are usually pretty good about using "Delete" when there is a destructive action, and "Remove" when there is not. Also, we have used "Remove Image" on the Appearance > Header and Background screens probably since they were introduced.

#5 @chriscct7
3 months ago

  • Keywords needs-patch added
  • Severity changed from minor to normal
Note: See TracTickets for help on using tickets.