WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 5 weeks ago

#22164 new enhancement

Move comment "keyboard shortcuts" setting to comments -> screen options

Reported by: lessbloat Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Comments Keywords: needs-refresh dev-feedback
Focuses: administration Cc:

Description

Seems like it would make more sense to move the comment "keyboard shortcuts" setting from "Your Profile" to the screen options pane of edit-comments.php. Something like:

http://f.cl.ly/items/1k210Z2V1o0b350I1n0V/keyboard-shortcuts.jpg

Attachments (2)

22164.patch (6.3 KB) - added by SergeyBiryukov 3 years ago.
22164.diff (3.6 KB) - added by nacin 3 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 @nacin3 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release

This was recently done on WordPress.com, and a few members of the core team reacted positively (including me, Mark, and Matt).

This goes in line with removing and simplifying options/settings screens in 3.5, so if it has a (simple) patch (soon), it could be considered.

@SergeyBiryukov3 years ago

comment:3 @SergeyBiryukov3 years ago

  • Keywords has-patch added; needs-patch removed

@nacin3 years ago

comment:4 follow-up: @nacin3 years ago

Played around with this today a bit. A few things:

1) Keyboard shortcuts should live-toggle based on the state of the checkbox.

2) I can't get $.hotkeys.remove() to work, as I think it tries to reach into long-gone jQuery internals. When looking into that, our jQuery Hotkeys plugin is terribly out of date. It is beta 2, by beta 7, it was completely rewritten, and then 3 years ago, Resig rewrote it: https://github.com/jeresig/jquery.hotkeys. If we can't hack in a fix to hotkeys, in order to update hotkeys, we'll need to rewrite our table_hotkeys.

I started on the front-end, while Sergey handled the backend. If we can work out how to remove events, we should be able to combine both patches.

comment:5 in reply to: ↑ 4 @SergeyBiryukov3 years ago

Replying to nacin:

our jQuery Hotkeys plugin is terribly out of date.

Related: #19489. Initial attempt at updating: ticket:20885:20885.patch.

Last edited 3 years ago by SergeyBiryukov (previous) (diff)

comment:6 @nacin3 years ago

This seems like a great thing for 3.6 early, I think. Definitely not as simple as it appears, and I think anything less than having it turn on and off immediately (and without a page refresh) is not worth it.

comment:7 @knutsp3 years ago

  • Cc knut@… added

comment:8 @chriscct74 months ago

  • Focuses administration added
  • Keywords needs-refresh dev-feedback added; has-patch removed

@nacin So the question is what is the disadvantage to removing that option completely and having keyboard shortcuts on by default and then just putting a link to the shortcuts on the screen options on comments?

comment:9 @celloexpressions5 weeks ago

+1 on getting this out of the profile screen however we can. Screen options was my initial thought, but if we could get rid of the option entirely I'd love to do that. I think the concern with on by default is that it could result in unexpected behavior for users not aware of the keyboard shortcuts, although I've never used them so not sure how much of an issue that might be.

comment:10 @helen5 weeks ago

I saw one or two people on the accessibility team discussing the potential ill effects on some types of keyboard navigation, like with screenreaders.

Note: See TracTickets for help on using tickets.