Make WordPress Core

Opened 3 years ago

Last modified 2 months ago

#22164 new enhancement

Move comment "keyboard shortcuts" setting to comments -> screen options

Reported by: lessbloat Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Comments Keywords: needs-refresh dev-feedback
Focuses: administration Cc:


Seems like it would make more sense to move the comment "keyboard shortcuts" setting from "Your Profile" to the screen options pane of edit-comments.php. Something like:


Attachments (2)

22164.patch (6.3 KB) - added by SergeyBiryukov 3 years ago.
22164.diff (3.6 KB) - added by nacin 3 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 @nacin3 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release

This was recently done on WordPress.com, and a few members of the core team reacted positively (including me, Mark, and Matt).

This goes in line with removing and simplifying options/settings screens in 3.5, so if it has a (simple) patch (soon), it could be considered.

@SergeyBiryukov3 years ago

comment:3 @SergeyBiryukov3 years ago

  • Keywords has-patch added; needs-patch removed

@nacin3 years ago

comment:4 follow-up: @nacin3 years ago

Played around with this today a bit. A few things:

1) Keyboard shortcuts should live-toggle based on the state of the checkbox.

2) I can't get $.hotkeys.remove() to work, as I think it tries to reach into long-gone jQuery internals. When looking into that, our jQuery Hotkeys plugin is terribly out of date. It is beta 2, by beta 7, it was completely rewritten, and then 3 years ago, Resig rewrote it: https://github.com/jeresig/jquery.hotkeys. If we can't hack in a fix to hotkeys, in order to update hotkeys, we'll need to rewrite our table_hotkeys.

I started on the front-end, while Sergey handled the backend. If we can work out how to remove events, we should be able to combine both patches.

comment:5 in reply to: ↑ 4 @SergeyBiryukov3 years ago

Replying to nacin:

our jQuery Hotkeys plugin is terribly out of date.

Related: #19489. Initial attempt at refactoring table-hotkeys.js: ticket:20885:20885.patch.

Version 0, edited 3 years ago by SergeyBiryukov (next)

comment:6 @nacin3 years ago

This seems like a great thing for 3.6 early, I think. Definitely not as simple as it appears, and I think anything less than having it turn on and off immediately (and without a page refresh) is not worth it.

comment:7 @knutsp3 years ago

  • Cc knut@… added

comment:8 @chriscct72 months ago

  • Focuses administration added
  • Keywords needs-refresh dev-feedback added; has-patch removed

@nacin So the question is what is the disadvantage to removing that option completely and having keyboard shortcuts on by default and then just putting a link to the shortcuts on the screen options on comments?

Note: See TracTickets for help on using tickets.