Make WordPress Core

Opened 12 years ago

Last modified 5 years ago

#22164 new enhancement

Move comment "keyboard shortcuts" setting to comments -> screen options

Reported by: lessbloat's profile lessbloat Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Comments Keywords: needs-refresh dev-feedback
Focuses: administration Cc:


Seems like it would make more sense to move the comment "keyboard shortcuts" setting from "Your Profile" to the screen options pane of edit-comments.php. Something like:

Attachments (2)

22164.patch (6.3 KB) - added by SergeyBiryukov 12 years ago.
22164.diff (3.6 KB) - added by nacin 12 years ago.

Download all attachments as: .zip

Change History (12)

#1 @nacin
12 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release

This was recently done on, and a few members of the core team reacted positively (including me, Mark, and Matt).

This goes in line with removing and simplifying options/settings screens in 3.5, so if it has a (simple) patch (soon), it could be considered.

#3 @SergeyBiryukov
12 years ago

  • Keywords has-patch added; needs-patch removed

12 years ago

#4 follow-up: @nacin
12 years ago

Played around with this today a bit. A few things:

1) Keyboard shortcuts should live-toggle based on the state of the checkbox.

2) I can't get $.hotkeys.remove() to work, as I think it tries to reach into long-gone jQuery internals. When looking into that, our jQuery Hotkeys plugin is terribly out of date. It is beta 2, by beta 7, it was completely rewritten, and then 3 years ago, Resig rewrote it: If we can't hack in a fix to hotkeys, in order to update hotkeys, we'll need to rewrite our table_hotkeys.

I started on the front-end, while Sergey handled the backend. If we can work out how to remove events, we should be able to combine both patches.

#5 in reply to: ↑ 4 @SergeyBiryukov
12 years ago

Replying to nacin:

our jQuery Hotkeys plugin is terribly out of date.

Related: #19489. Initial attempt at refactoring table-hotkeys.js: ticket:20885:20885.patch.

Version 0, edited 12 years ago by SergeyBiryukov (next)

#6 @nacin
12 years ago

This seems like a great thing for 3.6 early, I think. Definitely not as simple as it appears, and I think anything less than having it turn on and off immediately (and without a page refresh) is not worth it.

#7 @knutsp
11 years ago

  • Cc knut@… added

#8 @chriscct7
9 years ago

  • Focuses administration added
  • Keywords needs-refresh dev-feedback added; has-patch removed

@nacin So the question is what is the disadvantage to removing that option completely and having keyboard shortcuts on by default and then just putting a link to the shortcuts on the screen options on comments?

#9 @celloexpressions
9 years ago

+1 on getting this out of the profile screen however we can. Screen options was my initial thought, but if we could get rid of the option entirely I'd love to do that. I think the concern with on by default is that it could result in unexpected behavior for users not aware of the keyboard shortcuts, although I've never used them so not sure how much of an issue that might be.

#10 @helen
9 years ago

I saw one or two people on the accessibility team discussing the potential ill effects on some types of keyboard navigation, like with screenreaders.

Note: See TracTickets for help on using tickets.