WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 5 months ago

#22171 closed defect (bug) (fixed)

Merge Blogger Importer description strings

Reported by: SergeyBiryukov Owned by:
Milestone: WordPress.org Priority: normal
Severity: normal Version:
Component: WordPress.org site Keywords: has-patch
Focuses: Cc:

Description (last modified by SergeyBiryukov)

In Blogger Importer 0.4, the description strings were:

  • "Import posts, comments, tags, and attachments from a Blogger blog." (ref)
  • "Import posts, comments, and users from a Blogger blog." (ref)

In Blogger Importer 0.5:

  • "Import posts, comments and tags from a Blogger blog and migrate authors to Wordpress users." (ref)
  • "Import categories, posts and comments then maps users from a Blogger blog." (ref)

The core still says:

  • "Install the Blogger importer to import posts, comments, and users from a Blogger blog." (ref)

I guess we should merge the strings or at least fix the capital P.

Attachments (5)

22171.patch (1.2 KB) - added by SergeyBiryukov 3 years ago.
22171.2.patch (1.2 KB) - added by SergeyBiryukov 3 years ago.
22171.3.patch (3.3 KB) - added by SergeyBiryukov 3 years ago.
22171.4.patch (3.3 KB) - added by SergeyBiryukov 3 years ago.
Replaced "tags" with "categories"
22171.5.patch (4.0 KB) - added by SergeyBiryukov 5 months ago.

Download all attachments as: .zip

Change History (15)

#1 @Workshopshed
3 years ago

Sergey, the reason for changing the text is that it's never actually imported users. It only updates the posts with an author of your choice.

Last edited 3 years ago by Workshopshed (previous) (diff)

#2 @SergeyBiryukov
3 years ago

Thanks for the clarification. Would 22171.2.patch be more accurate?

22171.3.patch also fixes the capital P in readme.txt.

#3 @Workshopshed
3 years ago

Looks good, the only question is the tags. The importer converts blogger "labels" to WordPress "categories"

@SergeyBiryukov
3 years ago

Replaced "tags" with "categories"

#4 @chriscct7
5 months ago

  • Component changed from Import to WordPress.org site
  • Keywords needs-refresh added

#5 @samuelsidler
5 months ago

@Otto42: You just touched this code, worth fixing up? :)

#6 @Otto42
5 months ago

We can change the strings in the plugin around if it's deemed necessary.

There's two strings in the latest version which seem relevant and which could be unified:

"Imports posts, comments, images and tags from a Blogger blog then migrates authors to WordPress users."
"Import categories, posts, images and comments then maps users from a Blogger blog."

They could be unified. Not sure what the benefit would be, given that all plugins are going into translate, but if there's a good string replacement for both of these, then I'm happy to put it in there.

#7 @SergeyBiryukov
5 months ago

  • Description modified (diff)

#8 @Otto42
5 months ago

  • Resolution set to fixed
  • Status changed from new to closed

Change made to trunk version of the plugin, will update stable after additional changes.

http://plugins.trac.wordpress.org/changeset/1236506

#9 @SergeyBiryukov
5 months ago

  • Keywords needs-refresh removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

@Otto42: While we're at it, let's also fix the lowercase P, see 22171.5.patch.

#10 @Otto42
5 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

https://plugins.trac.wordpress.org/changeset/1236528

Don't know why trac isn't showing the changes to three files, but, fixed in trunk.

Note: See TracTickets for help on using tickets.