image_make_intermediate_size in wp-includes/media.php always returns FALSE

[gandham]

Found this when one of my theme user running 3.5 reported problem with thumbnails.
​http://swiftthemes.com/forums/showthread.php?1958-here-we-go-again-thumbnail-featured-pics-dont-work-in-latest-build-of-wordpress&goto=newpost#post7055

In the following function, if statement is followed by a ;, so this always returns false.

function image_make_intermediate_size( $file, $width, $height, $crop = false ) {
	if ( $width || $height ) {
		$editor = WP_Image_Editor::get_instance( $file );

		if ( is_wp_error( $editor ) || is_wp_error( $editor->resize( $width, $height, $crop ) ) );
			return false;

		$resized_file = $editor->save();

		if ( ! is_wp_error( $resized_file ) && $resized_file ) {
			unset( $resized_file['path'] );
			return $resized_file;
		}
	}
	return false;
}

[gandham]

Simple patch.

[nacin]

In [22225]:

Fix typo and don't always return false from image_make_intermediate_size(). props gandham, see #22181.

[nacin]

I don't like that no unit tests failed for this.

[markoheijnen]

I will now look in to that.

[markoheijnen]

Created a ticket at the unit test trac for this. It does include a file with four tests. See ​#UT135