Context Navigation

← Previous Ticket
Next Ticket →

#22203 closed defect (bug) (fixed)

WP_DEBUG - class wpdb prints errors while WP_DEBUG_DISPLAY is set to false

Reported by:	storkontheroof	Owned by:	SergeyBiryukov
Priority:	normal	Milestone:	3.6
Component:	Database	Version:	2.9
Severity:	normal	Keywords:	has-patch commit
Cc:		Focuses:

Description

The wpdb class prints errors when WP_DEBUG is true:

/wp-includes/wp-db.php line 539/540:

if ( WP_DEBUG )
    $this->show_errors();

To me seems this should be WP_DEBUG_DISPLAY.

My settings:

define('WP_DEBUG',         true);
define('WP_DEBUG_DISPLAY', false);
define('WP_DEBUG_LOG',     true);

So logging should be enabled, but display them on screen shouldn't.

Attachments (2)

22203.patch (462 bytes ) - added by crazycoders 13 years ago.: Suggested fix
22203.2.patch (450 bytes ) - added by SergeyBiryukov 13 years ago.: Fixed formatting and a typo

Download all attachments as: .zip

Change History (14)

#1 @SergeyBiryukov
14 years ago

Component General → Database

#2 @storkontheroof
14 years ago

Severity normal → critical

#3 @SergeyBiryukov
14 years ago

Version trunk → 2.9

#4 @cheeserolls
13 years ago

Should be:

if ( WP_DEBUG && WP_DEBUG_DISPLAY )

$this->show_errors();

@crazycoders
13 years ago

Attachment 22203.patch added

Suggested fix

#5 @crazycoders
13 years ago

Cc crazycoders added
Keywords has-patch added

@SergeyBiryukov
13 years ago

Attachment 22203.2.patch added

Fixed formatting and a typo

#6 @SergeyBiryukov
13 years ago

Milestone Awaiting Review → 3.6
Severity critical → normal

#7 follow-up: ↓ 8 @crazycoders
13 years ago

Why remove the {} in my patch, it's not good programming practice man? I agree with the && instead of & although both do exactly the same thing in this context...

#8 in reply to: ↑ 7 @SergeyBiryukov
13 years ago

Replying to crazycoders:

Why remove the {} in my patch, it's not good programming practice man?

See http://codex.wordpress.org/WordPress_Coding_Standards#Brace_Style.

#9 @DrewAPicture
13 years ago

22203.2.patch works as expected for me.

#10 @SergeyBiryukov
13 years ago

Keywords commit added

#11 @kovshenin
13 years ago

22203.2.patch works like a charm.

#12 @SergeyBiryukov
13 years ago

Owner set to SergeyBiryukov
Resolution → fixed
Status new → closed

In 24027:

Only show database errors if WP_DEBUG_DISPLAY is enabled. props cheeserolls, storkontheroof, crazycoders. fixes #22203.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#22203 closed defect (bug) (fixed)

WP_DEBUG - class wpdb prints errors while WP_DEBUG_DISPLAY is set to false

Description

Attachments (2)

Change History (14)

#1 @SergeyBiryukov 14 years ago

#2 @storkontheroof 14 years ago

#3 @SergeyBiryukov 14 years ago

#4 @cheeserolls 13 years ago

@crazycoders 13 years ago

#5 @crazycoders 13 years ago

@SergeyBiryukov 13 years ago

#6 @SergeyBiryukov 13 years ago

#7 follow-up: ↓ 8 @crazycoders 13 years ago

#8 in reply to: ↑ 7 @SergeyBiryukov 13 years ago

#9 @DrewAPicture 13 years ago

#10 @SergeyBiryukov 13 years ago

#11 @kovshenin 13 years ago

#12 @SergeyBiryukov 13 years ago