Opened 12 years ago
Closed 12 years ago
#22203 closed defect (bug) (fixed)
WP_DEBUG - class wpdb prints errors while WP_DEBUG_DISPLAY is set to false
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 3.6 | Priority: | normal |
Severity: | normal | Version: | 2.9 |
Component: | Database | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
The wpdb class prints errors when WP_DEBUG is true:
/wp-includes/wp-db.php line 539/540:
if ( WP_DEBUG ) $this->show_errors();
To me seems this should be WP_DEBUG_DISPLAY.
My settings:
define('WP_DEBUG', true); define('WP_DEBUG_DISPLAY', false); define('WP_DEBUG_LOG', true);
So logging should be enabled, but display them on screen shouldn't.
Attachments (2)
Change History (14)
#6
@
12 years ago
- Milestone changed from Awaiting Review to 3.6
- Severity changed from critical to normal
#7
follow-up:
↓ 8
@
12 years ago
Why remove the {} in my patch, it's not good programming practice man? I agree with the && instead of & although both do exactly the same thing in this context...
#8
in reply to:
↑ 7
@
12 years ago
Replying to crazycoders:
Why remove the {} in my patch, it's not good programming practice man?
See http://codex.wordpress.org/WordPress_Coding_Standards#Brace_Style.
#9
@
12 years ago
22203.2.patch works as expected for me.
#11
@
12 years ago
22203.2.patch works like a charm.
Note: See
TracTickets for help on using
tickets.
Should be: