WordPress.org

Make WordPress Core

#22206 closed task (blessed) (fixed)

Edit attachment display properties in the media modal

Reported by: koopersmith Owned by: koopersmith
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.5
Component: Media Keywords:
Focuses: Cc:

Description

The global attachment display properties should be editable from the media modal — these control how images are inserted into any editor. While images can be inserted in bulk, these settings should not be per-image, as there are not robust controls for the order of image insertion either (i.e. they are bulk properties for a bulk action).

Change History (4)

comment:1 koopersmith18 months ago

  • Owner set to koopersmith
  • Resolution set to fixed
  • Status changed from new to closed

In [22247]:

Add attachment display settings to the media modal.

  • Add a media view for button groups.
  • Add button dropdown containers.
  • Add a dropdown property to the button media model.

fixes #22206, #21814, see #21390, #21813, #21598.

comment:2 lessbloat18 months ago

This is looking really slick.

One thing that made me pause (if only momentarily) was that once I changed my display properties I didn't see a way to save them:

http://f.cl.ly/items/111j0k0o2F1V451U1d2k/attachment-properties.jpg

After looking for a second, I guessed that the "Insert into post" button likely still worked (and it did), but the point is, I had to stop and think about it.

Could we do something like this:

http://f.cl.ly/items/2h0G382336213E0G1507/attachment-props-proposal.jpg

Which sits just over the top of the first button?

comment:3 nacin18 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

After looking for a second, I guessed that the "Insert into post" button likely still worked (and it did), but the point is, I had to stop and think about it.

koopersmith and I had mocked up a second button at the bottom (which is likely less jarring as it feels like less of an AYS). Either way, something needs to be done.

comment:4 koopersmith18 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 22493:

Media: Add size dropdown to attachment display settings in the media modal. fixes #22206, see #21390.

Note: See TracTickets for help on using tickets.