Opened 12 years ago
Closed 12 years ago
#22207 closed defect (bug) (worksforme)
patch for adding proxy support to SimplePie class
Reported by: | mrnipper | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | 3.4.2 |
Component: | Feeds | Keywords: | has-patch |
Focuses: | Cc: |
Description
Please incorporate the following patch into the SimplePie class built-in to WordPress. It seems like an obvious oversight now that proxy support is supposedly built-in as well (but doesn't work with SimplePie when defining WP_PROXY_HOST in wp-config.php).
Attachments (1)
Change History (2)
#1
@
12 years ago
- Milestone Awaiting Review deleted
- Resolution set to worksforme
- Status changed from new to closed
When SimplePie is used via the WordPress API methods, it uses WP_HTTP for outgoing requests, which respects the proxy settings.
It sounds like you're using SimplePie directly, which means you have to do extra setup.
so either:
- (preferably) Use fetch_feed()
or
- Use the same logic inside fetch_feed() to set the File Class (
$sp->set_file_class()
) - but ONLY if for some reason, you can't use fetch_feed() AND you can't use thewp_feed_options
filter to set the custom options you need.
Note: See
TracTickets for help on using
tickets.
Simple patch to allow SimplePie class to use globally defined proxy, if defined.