Make WordPress Core

Opened 14 years ago

Closed 13 years ago

#22209 closed enhancement (fixed)

Simplify logic to generate home path when parsing request

Reported by: evansolomon Owned by: nacin
Priority: normal Milestone: 3.7
Component: Query Version:
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

In WP::parse_request() we go through a few steps to generate the $home_path variable. Since we now require PHP 5.2, we can use parse_url()'s second argument to get the path directly.

Attachments (1)

22209.diff​ (724 bytes ) - added by evansolomon 14 years ago.

Download all attachments as: .zip

Change History (4)

@evansolomon
14 years ago

#1 @scribu
14 years ago

That whole area could use some cleanup.

Like, replacing this:

$req_uri_array = explode('?', $req_uri);
$req_uri = $req_uri_array[0];

with this:

list( $req_uri ) = explode( '?', $req_uri );

or maybe even using parse_str().

Last edited 14 years ago by scribu (previous) (diff)

#2 @wonderboymusic
13 years ago

  • Milestone Awaiting Review → 3.7

Patch still applies - more cleanup code be done, but this works

#3 @nacin
13 years ago

  • Owner set to nacin
  • Resolution → fixed
  • Status new → closed

In 25617:

Clean up the path calculations in wp::parse_request().

props evansolomon for initial cleanup.
fixes #22209.

Note: See TracTickets for help on using tickets.