Context Navigation

← Previous Ticket
Next Ticket →

#22228 closed enhancement (fixed)

Remove one-time variable from add_settings_error

Reported by:	niallkennedy	Owned by:	SergeyBiryukov
Priority:	normal	Milestone:	4.0
Component:	Administration	Version:	3.0
Severity:	trivial	Keywords:	has-patch
Cc:		Focuses:

Description

Append an array to $wp_settings_errors without assigning it to a variable in the previous line.

Before:
$var = array( 'type' => $type ... );
$wp_settings_errors[] = $var;

After:
$wp_settings_errors[] = array( 'type' => $type ... );

Attachments (2)

template.diff (653 bytes ) - added by niallkennedy 14 years ago.: append array directly to $wp_settings_errors
22228.diff (700 bytes ) - added by obenland 13 years ago.: Refreshed patch

Download all attachments as: .zip

Change History (6)

@niallkennedy
14 years ago

Attachment template.diff added

append array directly to $wp_settings_errors

@obenland
13 years ago

Attachment 22228.diff added

Refreshed patch

#1 @obenland
13 years ago

Keywords has-patch added
Version → 3.0

#2 @SergeyBiryukov
12 years ago

Milestone Awaiting Review → 4.0

#3 @SergeyBiryukov
12 years ago

Owner set to SergeyBiryukov
Resolution → fixed
Status new → closed

In 28681:

Remove one-time variable from add_settings_error().

props niallkennedy.
fixes #22228.

This ticket was mentioned in Slack in #core-editor by zieladam. View the logs.

6 years ago

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#22228 closed enhancement (fixed)

Remove one-time variable from add_settings_error

Description

Attachments (2)

Change History (6)

@niallkennedy 14 years ago

@obenland 13 years ago

#1 @obenland 13 years ago

#2 @SergeyBiryukov 12 years ago

#3 @SergeyBiryukov 12 years ago

This ticket was mentioned in ​Slack in #core-editor by zieladam. ​View the logs. 6 years ago