![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
#22233 closed defect (bug) (fixed)
update_option() fails when value has nested objects
| Reported by: | exz | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | 3.6 |
| Component: | Options, Meta APIs | Version: | 3.4.2 |
| Severity: | normal | Keywords: | |
| Cc: | Focuses: |
Description
This gist has an example of how this problem can be reproduced: https://gist.github.com/3923757
If you run the three functions in three separate page loads you will see that the foo attribute of $b doesn't get saved. It seems to be some kind of cache problem.
I've been able to reproduce this in 3.4.2, 3.4.3-alpha and 3.5-beta2
Attachments (1)
Change History (17)
#1
@
14 years ago
- Component General → Cache
- Keywords reporter-feedback added; update_option cache removed
#3
@
14 years ago
Just realized that this could be tested without the need for multiple page loads. I created a unit test for it: https://gist.github.com/3923951
$ phpunit tests/option/option.php Installing... Running as single site... To run multisite, use -c multisite.xml Not running ajax tests... To execute these, use --group ajax. PHPUnit 3.6.11 by Sebastian Bergmann. Configuration read from /Users/rickard/unit-test.svn.wordpress.org/trunk/phpunit.xml ...F Time: 1 second, Memory: 42.00Mb There was 1 failure: 1) Tests_Option_Option::test_multiple_calls Failed asserting that false is true. /Users/rickard/unit-test.svn.wordpress.org/trunk/tests/option/option.php:92 /usr/bin/phpunit:46 FAILURES! Tests: 4, Assertions: 31, Failures: 1.
#4
@
14 years ago
@scribu I have the memcache module installed but not APC. I verified it using a clean install of 3.4.3-alpha and 3.5-beta
#6
@
14 years ago
- Severity normal → minor
Confirmed. It seems this check if ( $newvalue === $oldvalue ) isn't enough. PHP probably just compares the internal object ids, rather than the values.
A possible solution would be to make the cloning recursive:
if ( is_object($newvalue) ) $newvalue = clone $newvalue;
#8
@
14 years ago
- Summary Multiple calls to update_option with the same array only saves the first time → update_option() fails when value has nested objects
#13
@
11 years ago
- Keywords needs-patch needs-testing removed
- Resolution → worksforme
- Status new → closed
I've been trying to reproduce this issue in order to fix it and have not been able to.
Went back as far as WP 3.7-RC1 to run the unit test and it just keeps passing.
Probably got fixed "accidentally" somewhere along the way between WP 3.5 and WP 3.7, though I can't see anything in the code to pinpoint what would have fixed it.
@exz do you still have a problem with this ? and if so, could you provide a unit test which will fail on trunk ?
If not, I suggest this ticket should be closed, though it might be a good idea to add the unit test to the test suite all the same.
I'll upload a patch which will add @exz's unit test for this. Props @exz.
So, you have a persistent cache enabled (Memcache, APC etc.), right?