PHP Notice On _remove_theme_support() function

[alex-ye]

Hi Guys , I just found this PHP Notice on _remove_theme_support() function , Tested On :

1 - WordPress 3.5 Beta 2

2 - PHP 5.4

To get this notice on just add child theme to TwentyTwelve and add this simple code on functions.php :

add_action ( 'after_setup_theme', 'Nash_setup' , 11 );

function Nash_setup() {

    remove_theme_support ( 'custom-background' );   
    remove_theme_support ( 'custom-header' );    

} // end Nash_setup()

[alex-ye]

Using isset() to fix the bug

[SergeyBiryukov]

With proper formatting

[ryan]

In [22274]:

Avoid notices in _remove_theme_support(). Props alex-ye, SergeyBiryukov. fixes #22246

[nacin]

Rather than papering over the notices in [22274], we can bail in the particular situation where this occurs: When the "just in time" initialization hasn't occurred yet, we don't need to do anything beyond unsetting the item from the global array. See 22246.diff​ (made against pre-[22274]).

[nacin]

Made against head.

[obenland]

#21905 was marked as a duplicate.

[ryan]

Fine with 22246.2.diff.

[nacin]

In [22312]:

Revert [22274]. see #22246.

[nacin]

In [22313]:

If we have not yet initialized the custom header/background, do not do extra removal in _remove_theme_support(). fixes #22246.

[alex-ye]

As I test the PHP notice is still exists even after Nacin patch .
I just add isset() function to check the array :)

[alex-ye]

Using isset() after nacin patch

[SergeyBiryukov]

This ticket was closed on a completed milestone. Please open a new one.

[SergeyBiryukov]

Follow-up: #23170

[SergeyBiryukov]

In 23367:

Properly check if the custom header/background has been initialized. fixes #23170. see #22246.