Context Navigation

← Previous Ticket
Next Ticket →

#22246 closed defect (bug) (fixed)

PHP Notice On _remove_theme_support() function

Reported by:	alex-ye	Owned by:	ryan
Priority:	normal	Milestone:	3.5
Component:	Warnings/Notices	Version:	3.4.2
Severity:	normal	Keywords:	has-patch
Cc:		Focuses:

Description

Hi Guys , I just found this PHP Notice on _remove_theme_support() function , Tested On :

1 - WordPress 3.5 Beta 2

2 - PHP 5.4

To get this notice on just add child theme to TwentyTwelve and add this simple code on functions.php :

add_action ( 'after_setup_theme', 'Nash_setup' , 11 );

function Nash_setup() {

    remove_theme_support ( 'custom-background' );   
    remove_theme_support ( 'custom-header' );    

} // end Nash_setup()

Attachments (5)

theme.php.patch (1.4 KB ) - added by alex-ye 14 years ago.: Using isset() to fix the bug
22246.patch (1.4 KB ) - added by SergeyBiryukov 14 years ago.: With proper formatting
22246.diff (889 bytes ) - added by nacin 14 years ago.
22246.2.diff (1.6 KB ) - added by nacin 14 years ago.: Made against head.
theme.php.2.patch (1.2 KB ) - added by alex-ye 14 years ago.: Using isset() after nacin patch

Download all attachments as: .zip

Change History (18)

@alex-ye
14 years ago

Attachment theme.php.patch added

Using isset() to fix the bug

#1 @alex-ye
14 years ago

Keywords has-patch added; needs-patch removed

@SergeyBiryukov
14 years ago

Attachment 22246.patch added

With proper formatting

#2 @SergeyBiryukov
14 years ago

Component Themes → Warnings/Notices
Milestone Awaiting Review → 3.5

#3 @ryan
14 years ago

Owner set to ryan
Resolution → fixed
Status new → closed

In [22274]:

Avoid notices in _remove_theme_support(). Props alex-ye, SergeyBiryukov. fixes #22246

@nacin
14 years ago

Attachment 22246.diff added

#4 @nacin
14 years ago

Resolution fixed
Status closed → reopened

Rather than papering over the notices in [22274], we can bail in the particular situation where this occurs: When the "just in time" initialization hasn't occurred yet, we don't need to do anything beyond unsetting the item from the global array. See 22246.diff (made against pre-[22274]).