WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #22252, comment 14


Ignore:
Timestamp:
11/11/12 21:54:06 (17 months ago)
Author:
nacin
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #22252, comment 14

    initial v1  
    33The problem is that by this point, only one theme root exists, so template_root and stylesheet_root are left untouched. Deleting them here would fix most of these issues. 
    44 
    5 The remaining issue is that validate_current_theme() should actually validate that any stored theme roots are accurate, to catch potential edge cases. (Such as when the same bp-default theme is in both roots, then one of the roots disappears.) I'd like to try doing that without causing non-existent option calls on single-site, though. Basically: 
     5The remaining issue is that validate_current_theme() should actually validate that any stored theme roots are accurate, to catch potential edge cases. (Such as when the same bp-default theme is in both roots, then one of the roots disappears.) I'd like to try doing that without causing non-existent option calls ~~on single-site~~ when there is only one root, though. Basically: 
    66 * If there's one theme root, it should delete any _root options. 
    77 * If there's more than one theme root, it should make sure any _root options are accurate (similar to your code in switch_theme() in 2.patch).