Make WordPress Core

Opened 14 years ago

Closed 14 years ago

#22265 closed defect (bug) (fixed)

PHP Strict: WP_Customize_Filter_Setting::update() incompatible with parent method

Reported by: kurtpayne Owned by: nacin
Priority: normal Milestone: 3.5
Component: Warnings/Notices Version: 3.4
Severity: trivial Keywords: has-patch
Cc: Focuses:

Description

Full strict message:

Declaration of WP_Customize_Filter_Setting::update() should be compatible with that of WP_Customize_Setting::update()

This is happening because the declaration of WP_Customize_Filter_Setting::update doesn't accept a parameter.

On a different note, the original declaration of WP_Customize_Setting::update is protected. The visibility is changed to public, though, in WP_Customize_Filter_Setting, WP_Customize_Header_Image_Setting, and WP_Customize_Background_Image_Setting.

Attachments (1)

22265.patch​ (372 bytes ) - added by kurtpayne 14 years ago.

Download all attachments as: .zip

Change History (4)

@kurtpayne
14 years ago

#1 @kurtpayne
14 years ago

  • Keywords has-patch added

#2 @SergeyBiryukov
14 years ago

  • Milestone Awaiting Review → 3.5

#3 @nacin
14 years ago

  • Owner set to nacin
  • Resolution → fixed
  • Status new → closed

In 22448:

Ensure a method is compatible with its parent. props kurtpayne, fixes #22265.

Note: See TracTickets for help on using tickets.