WordPress.org

Make WordPress Core

#22265 closed defect (bug) (fixed)

PHP Strict: WP_Customize_Filter_Setting::update() incompatible with parent method

Reported by: kurtpayne Owned by: nacin
Milestone: 3.5 Priority: normal
Severity: trivial Version: 3.4
Component: Warnings/Notices Keywords: has-patch
Focuses: Cc:

Description

Full strict message:

Declaration of WP_Customize_Filter_Setting::update() should be compatible with that of WP_Customize_Setting::update()

This is happening because the declaration of WP_Customize_Filter_Setting::update doesn't accept a parameter.

On a different note, the original declaration of WP_Customize_Setting::update is protected. The visibility is changed to public, though, in WP_Customize_Filter_Setting, WP_Customize_Header_Image_Setting, and WP_Customize_Background_Image_Setting.

Attachments (1)

22265.patch (372 bytes) - added by kurtpayne 18 months ago.

Download all attachments as: .zip

Change History (4)

kurtpayne18 months ago

comment:1 kurtpayne18 months ago

  • Keywords has-patch added

comment:2 SergeyBiryukov18 months ago

  • Milestone changed from Awaiting Review to 3.5

comment:3 nacin18 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 22448:

Ensure a method is compatible with its parent. props kurtpayne, fixes #22265.

Note: See TracTickets for help on using tickets.