WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #22271, comment 27


Ignore:
Timestamp:
11/05/12 18:13:07 (2 years ago)
Author:
Rarst
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #22271, comment 27

    initial v1  
    22 
    33 - `get_post_class()` does not pass post object, only ID. Any filter will have to retrieve post object anyway... and as for me it's filter's problem if it doesn't check that if that came up with something. 
    4  - there are other filters that will happily pass non-valid ID, for example `get_the_title`. So case can be made that specific `get_post_title` filter ''historically'' only passes valid ID, but there is no general case that filter passing ID as additional argument must ensure that it is valid one. 
     4 - there are other filters that will happily pass non-valid ID, for example `get_the_title`. So case can be made that specific `get_post_class` filter ''historically'' only passes valid ID, but there is no general case that filter passing ID as additional argument must ensure that it is valid one. 
    55 
    66PS introducing new filter doesn't make sense to me because I don't see strong case to not just apply existing to all cases and be done.