Make WordPress Core

Opened 3 years ago

Last modified 3 weeks ago

#22277 assigned enhancement

Admin (not just superadmin) should be able to add user without confirmation email in multisite

Reported by: jane Owned by: morganestes
Milestone: Future Release Priority: normal
Severity: normal Version: 3.4.2
Component: Users Keywords: has-patch needs-refresh
Focuses: administration, multisite Cc:


I don't know why admins would be restricted from adding existing users without sending them a confirmation, but they are in multisite. You have to be a superadmin to get that option. I think that is lame, and would like to see admins have that admin option. Is there is a reason why it is that way (security etc)? Since neither @markjaquith nor I could remember a reason, making this ticket and hoping we fix it.

Attachments (4)

22277.patch (2.7 KB) - added by SergeyBiryukov 3 years ago.
22277.2.patch (2.7 KB) - added by DrewAPicture 2 years ago.
22277.3.diff (2.7 KB) - added by jeremyfelt 2 years ago.
Refresh for trunk
22277.4.diff (2.9 KB) - added by jonathanbardo 11 months ago.
Refresh against 4.1-beta1

Download all attachments as: .zip

Change History (28)

comment:1 @scribu3 years ago

  • Cc scribu added

@SergeyBiryukov3 years ago

comment:2 @toscho3 years ago

  • Cc info@… added

comment:3 @SergeyBiryukov3 years ago

  • Keywords has-patch added

The original code was introduced in mu:1852.

comment:4 @knutsp3 years ago

  • Cc knut@… added

comment:5 @SergeyBiryukov3 years ago

  • Milestone changed from Awaiting Review to 3.6

comment:6 @sabreuse3 years ago

  • Cc sabreuse added

@DrewAPicture2 years ago


comment:7 @DrewAPicture2 years ago

22277.2.patch refreshes against trunk.

The patch works as expected.

comment:8 @SergeyBiryukov2 years ago

  • Keywords commit added

comment:9 @m_uysl2 years ago

  • Cc m_uysl@… added

comment:10 follow-up: @nacin2 years ago

  • Milestone changed from 3.6 to Future Release

Too late for this change. Probably needs a filter or something, too.

Some background: This was deliberately for multi-user setups, to prevent random administrators from spamming other users with invites. (Until maybe a year or two ago, WP.com still allowed only emails.) Obviously, it does not make sense for more traditional networks. Making that a distinction across core could go along way to solving not just this.

comment:11 @ryanduff2 years ago

This looks to be a dupe of #20221

comment:12 @DrewAPicture2 years ago

  • Keywords 2nd-opinion added; commit removed

Kind of interesting to see the two different approaches the to same problem.

The patch here, 22277.2.patch seems better because:

I suggest we close #20221 in favor of the patch here.

@jeremyfelt2 years ago

Refresh for trunk

comment:13 in reply to: ↑ 10 @jeremyfelt2 years ago

  • Keywords 2nd-opinion removed
  • Milestone changed from Future Release to 3.7

2227.3.diff is a refresh of DrewAPicture's patch for trunk. Moving to 3.7 for discussion.

Replying to nacin:

Too late for this change. Probably needs a filter or something, too.

Filter just for display of the checkbox?

comment:14 @SergeyBiryukov2 years ago

#20221 was marked as a duplicate.

comment:15 @sc0ttkclark2 years ago

  • Cc lol@… added

comment:16 @dnaber-de2 years ago

  • Cc kontakt@… added

comment:17 @nacin2 years ago

  • Milestone changed from 3.7 to 3.8

comment:18 @jeremyfelt23 months ago

  • Milestone changed from 3.8 to Future Release
  • Type changed from defect (bug) to enhancement

Pushing to a future release. I'll take a closer look in the 3.9 cycle. Moved from bug to enhancement due to original intent.

comment:19 @jeremyfelt21 months ago

  • Component changed from Multisite to Users
  • Focuses multisite added

comment:20 follow-up: @rbmg-wp18 months ago

Apologies if this is the wrong place to ask this but wondering if this ticket has made it into 3.9? Thanks...

comment:21 in reply to: ↑ 20 @samuelsidler18 months ago

Replying to rbmg-wp:

Apologies if this is the wrong place to ask this but wondering if this ticket has made it into 3.9? Thanks...

As you can see, this ticket is currently targeted at a "Future Milestone" and is marked as "new" (as opposed to "closed fixed"). It will not be in 3.9.

There's a patch. Let's take a look again early in the 4.0 cycle.

comment:22 @samuelsidler18 months ago

  • Keywords 4.0-early added

@jonathanbardo11 months ago

Refresh against 4.1-beta1

comment:23 @morganestes3 weeks ago

  • Focuses administration added
  • Keywords needs-refresh added; 4.0-early removed

comment:24 @morganestes3 weeks ago

  • Owner set to morganestes
  • Status changed from new to assigned
Note: See TracTickets for help on using tickets.