Opened 12 years ago
Last modified 6 years ago
#22277 assigned enhancement
Admin (not just superadmin) should be able to add user without confirmation email in multisite
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | 3.4.2 |
Component: | Users | Keywords: | has-patch needs-refresh 2nd-opinion |
Focuses: | administration, multisite | Cc: |
Description
I don't know why admins would be restricted from adding existing users without sending them a confirmation, but they are in multisite. You have to be a superadmin to get that option. I think that is lame, and would like to see admins have that admin option. Is there is a reason why it is that way (security etc)? Since neither @markjaquith nor I could remember a reason, making this ticket and hoping we fix it.
Attachments (4)
Change History (30)
#7
@
12 years ago
22277.2.patch refreshes against trunk.
The patch works as expected.
#10
follow-up:
↓ 13
@
12 years ago
- Milestone changed from 3.6 to Future Release
Too late for this change. Probably needs a filter or something, too.
Some background: This was deliberately for multi-user setups, to prevent random administrators from spamming other users with invites. (Until maybe a year or two ago, WP.com still allowed only emails.) Obviously, it does not make sense for more traditional networks. Making that a distinction across core could go along way to solving not just this.
#12
@
12 years ago
- Keywords 2nd-opinion added; commit removed
Kind of interesting to see the two different approaches the to same problem.
The patch here, 22277.2.patch seems better because:
- it doesn't needlessly check the
promote_users
cap like ticket:20221:user-new.2.patch does - ticket:20221:user-new.2.patch incorrectly changes the
is_super_admin()
check on theget_user_by( 'login'
call since only super admins can add existing users by login anyway
I suggest we close #20221 in favor of the patch here.
#13
in reply to:
↑ 10
@
12 years ago
- Keywords 2nd-opinion removed
- Milestone changed from Future Release to 3.7
2227.3.diff is a refresh of DrewAPicture's patch for trunk. Moving to 3.7 for discussion.
Replying to nacin:
Too late for this change. Probably needs a filter or something, too.
Filter just for display of the checkbox?
#18
@
11 years ago
- Milestone changed from 3.8 to Future Release
- Type changed from defect (bug) to enhancement
Pushing to a future release. I'll take a closer look in the 3.9 cycle. Moved from bug to enhancement due to original intent.
#20
follow-up:
↓ 21
@
11 years ago
Apologies if this is the wrong place to ask this but wondering if this ticket has made it into 3.9? Thanks...
#21
in reply to:
↑ 20
@
11 years ago
Replying to rbmg-wp:
Apologies if this is the wrong place to ask this but wondering if this ticket has made it into 3.9? Thanks...
As you can see, this ticket is currently targeted at a "Future Milestone" and is marked as "new" (as opposed to "closed fixed"). It will not be in 3.9.
There's a patch. Let's take a look again early in the 4.0 cycle.
The original code was introduced in mu:1852.