WordPress.org

Make WordPress Core

Opened 4 years ago

Last modified 4 months ago

#22277 assigned enhancement

Admin (not just superadmin) should be able to add user without confirmation email in multisite

Reported by: jane Owned by: morganestes
Milestone: Future Release Priority: normal
Severity: normal Version: 3.4.2
Component: Users Keywords: has-patch needs-refresh 2nd-opinion
Focuses: administration, multisite Cc:

Description

I don't know why admins would be restricted from adding existing users without sending them a confirmation, but they are in multisite. You have to be a superadmin to get that option. I think that is lame, and would like to see admins have that admin option. Is there is a reason why it is that way (security etc)? Since neither @markjaquith nor I could remember a reason, making this ticket and hoping we fix it.

Attachments (4)

22277.patch (2.7 KB) - added by SergeyBiryukov 4 years ago.
22277.2.patch (2.7 KB) - added by DrewAPicture 3 years ago.
Refresh
22277.3.diff (2.7 KB) - added by jeremyfelt 3 years ago.
Refresh for trunk
22277.4.diff (2.9 KB) - added by jonathanbardo 21 months ago.
Refresh against 4.1-beta1

Download all attachments as: .zip

Change History (30)

#1 @scribu
4 years ago

  • Cc scribu added

#2 @toscho
4 years ago

  • Cc info@… added

#3 @SergeyBiryukov
4 years ago

  • Keywords has-patch added

The original code was introduced in mu:1852.

#4 @knutsp
4 years ago

  • Cc knut@… added

#5 @SergeyBiryukov
4 years ago

  • Milestone changed from Awaiting Review to 3.6

#6 @sabreuse
4 years ago

  • Cc sabreuse added

@DrewAPicture
3 years ago

Refresh

#7 @DrewAPicture
3 years ago

22277.2.patch refreshes against trunk.

The patch works as expected.

#8 @SergeyBiryukov
3 years ago

  • Keywords commit added

#9 @m_uysl
3 years ago

  • Cc m_uysl@… added

#10 follow-up: @nacin
3 years ago

  • Milestone changed from 3.6 to Future Release

Too late for this change. Probably needs a filter or something, too.

Some background: This was deliberately for multi-user setups, to prevent random administrators from spamming other users with invites. (Until maybe a year or two ago, WP.com still allowed only emails.) Obviously, it does not make sense for more traditional networks. Making that a distinction across core could go along way to solving not just this.

#11 @ryanduff
3 years ago

This looks to be a dupe of #20221

#12 @DrewAPicture
3 years ago

  • Keywords 2nd-opinion added; commit removed

Kind of interesting to see the two different approaches the to same problem.

The patch here, 22277.2.patch seems better because:

I suggest we close #20221 in favor of the patch here.

@jeremyfelt
3 years ago

Refresh for trunk

#13 in reply to: ↑ 10 @jeremyfelt
3 years ago

  • Keywords 2nd-opinion removed
  • Milestone changed from Future Release to 3.7

2227.3.diff is a refresh of DrewAPicture's patch for trunk. Moving to 3.7 for discussion.

Replying to nacin:

Too late for this change. Probably needs a filter or something, too.

Filter just for display of the checkbox?

#14 @SergeyBiryukov
3 years ago

#20221 was marked as a duplicate.

#15 @sc0ttkclark
3 years ago

  • Cc lol@… added

#16 @dnaber-de
3 years ago

  • Cc kontakt@… added

#17 @nacin
3 years ago

  • Milestone changed from 3.7 to 3.8

#18 @jeremyfelt
3 years ago

  • Milestone changed from 3.8 to Future Release
  • Type changed from defect (bug) to enhancement

Pushing to a future release. I'll take a closer look in the 3.9 cycle. Moved from bug to enhancement due to original intent.

#19 @jeremyfelt
3 years ago

  • Component changed from Multisite to Users
  • Focuses multisite added

#20 follow-up: @rbmg-wp
2 years ago

Apologies if this is the wrong place to ask this but wondering if this ticket has made it into 3.9? Thanks...

#21 in reply to: ↑ 20 @samuelsidler
2 years ago

Replying to rbmg-wp:

Apologies if this is the wrong place to ask this but wondering if this ticket has made it into 3.9? Thanks...

As you can see, this ticket is currently targeted at a "Future Milestone" and is marked as "new" (as opposed to "closed fixed"). It will not be in 3.9.

There's a patch. Let's take a look again early in the 4.0 cycle.

#22 @samuelsidler
2 years ago

  • Keywords 4.0-early added

@jonathanbardo
21 months ago

Refresh against 4.1-beta1

#23 @morganestes
11 months ago

  • Focuses administration added
  • Keywords needs-refresh added; 4.0-early removed

#24 @morganestes
11 months ago

  • Owner set to morganestes
  • Status changed from new to assigned

This ticket was mentioned in Slack in #core-multisite by soderlind. View the logs.


4 months ago

#26 @jeremyfelt
4 months ago

  • Keywords 2nd-opinion added

Related: #16860, which replaces is_super_admin() here with a manage_network_users check. We should revisit whether removing that capability is necessary, or whether we can close this ticket as fixed as well.

Note: See TracTickets for help on using tickets.