Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#22280 closed enhancement (wontfix)

Correcting class-http.php to use WordPress naming conventions

Reported by: danhgilmore Owned by:
Milestone: Priority: normal
Severity: minor Version: 3.5
Component: Formatting Keywords: has-patch
Focuses: Cc:


WordPress convention is to use underscores versus camelCase. I have changed the names of all the functions to adhere to WordPress standards.

Attachments (1)

class-http.diff (6.7 KB) - added by danhgilmore 3 years ago.

Download all attachments as: .zip

Change History (3)

comment:1 @nacin3 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

While this is our convention, it is too late for these to change, as these are all publicly accessible methods that plugins may be referencing directly. Note that renaming the methods themselves wouldn't be enough either way, as we'd need to update where they are called as well.

We *could* solve this with __call() but some of these are static methods, which means we'd need callStatic() in PHP 5.3. Ultimately, using magic methods to rename a few methods for standards reasons is a bit overkill anyway.

@danhgilmore3 years ago

comment:2 @danhgilmore3 years ago

@Nacin - Totally understand, but just FYI, I changed where the functions were being called in my second upload (FWIW)

Note: See TracTickets for help on using tickets.