Make WordPress Core

Opened 12 years ago

Closed 11 years ago

#22306 closed defect (bug) (fixed)

Some other string tweaks

Reported by: pavelevap's profile pavelevap Owned by: nacin's profile nacin
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.4
Component: I18N Keywords: has-patch 3.6-early commit
Focuses: Cc:

Description

There are some other string tweaks: removing duplicate strings, removing HTML from strings, adding
"WordPress ›" to title as usual, using the same string where possible, etc. As a result, there are less strings to translate and several shorter strings to translate. Please see attached patch for detailed ideas.

Attachments (5)

22306.patch (6.3 KB) - added by pavelevap 12 years ago.
22306.2.patch (4.0 KB) - added by pavelevap 12 years ago.
22306.3.patch (3.7 KB) - added by SergeyBiryukov 12 years ago.
Refreshed
22306.4.patch (1.5 KB) - added by SergeyBiryukov 12 years ago.
Just wp-signup.php
22306.5.patch (1.5 KB) - added by SergeyBiryukov 11 years ago.
Fixed closing tags, added missing comma

Download all attachments as: .zip

Change History (21)

@pavelevap
12 years ago

#1 @SergeyBiryukov
12 years ago

  • Milestone changed from Awaiting Review to 3.5

#2 @kovshenin
12 years ago

  • Keywords has-patch added

#3 @MikeHansenMe
12 years ago

Patch is simple enough +1 for commit.

#4 @nacin
12 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 22430:

Merge some strings. props pavelevap. fixes #22306.

#5 @nacin
12 years ago

I left out a few changes:

  • Did not see the need to add "a" to the ubiquitous "error establishing database connection" message.
  • I didn't want to break a bunch of long and long-standing strings a month left in the cycle just to remove some HTML from them.

@pavelevap
12 years ago

#6 @pavelevap
12 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Did not see the need to add "a" to the ubiquitous "error establishing database connection" message.

Because we have the same string with "a" and without "a". I removed "a" in other places in updated patch.

  • I didn't want to break a bunch of long and long-standing strings a month left in the cycle just to remove some HTML from them.

I do not think that one month is a big problem for translators. These strings contain the same sentences which can be then removed from localization files and there will be less work for translators in the end (only some of them were changed by removing HTML). I understand your reasons, but in this case we should not close this ticket?

I added some other little tweak in updated patch (removing double space).

#7 @nacin
12 years ago

In 22449:

Merge two strings. props pavelevap, see #22306.

@SergeyBiryukov
12 years ago

Refreshed

#8 @ryan
12 years ago

I'd rather not remove markup if it means breaking one string into two.

#9 @nacin
12 years ago

  • Milestone changed from 3.5 to Future Release

#10 @DrewAPicture
12 years ago

  • Cc xoodrew@… added

Looks like I'm late to the party, but I'd argue that use of <strong> or <em> tags inside a translatable string provides valid context for what requires emphasis.

I believe @otto42 may have touched on this in a recent blog post though this instance may not fall into what he'd consider a "rare" case where emphasis is warranted.

@SergeyBiryukov
12 years ago

Just wp-signup.php

#11 follow-up: @SergeyBiryukov
12 years ago

  • Keywords 3.6-early added

Per the IRC chat, 22306.4.patch can be done early next cycle.

#12 @SergeyBiryukov
12 years ago

  • Version changed from trunk to 3.4

#13 @SergeyBiryukov
11 years ago

  • Milestone changed from Future Release to 3.6

#14 in reply to: ↑ 11 @DrewAPicture
11 years ago

Replying to SergeyBiryukov:

Did you still want to try to get this in for 3.6 or again wait for 3.7 early?

@SergeyBiryukov
11 years ago

Fixed closing tags, added missing comma

#15 @SergeyBiryukov
11 years ago

  • Keywords commit added

#16 @nacin
11 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 24058:

Adjust some strings in wp-signup.php.

  • Remove double space.
  • Remove outer HTML.

props pavelevap, SergeyBiryukov.
fixes #22306.

Note: See TracTickets for help on using tickets.