Require at least PHP Imagick 2.1.1 (Imagick::queryFormats() called statically)

[mpvanwinkle77]

Media Uploader throws error on server where Imagick is enabled:

"PHP Fatal error: Non-static method Imagick::queryformats() cannot be called statically, assuming $this from incompatible context in /../..wp-includes/class-wp-image-editor-imagick.php on line 153"

[mpvanwinkle77]

FYI, installing Imagick module v3.0 ( apt-get install php5-imagick ) resolves the issue as well ... but the patch is probably good for backwards compatibility. And if the new media functions require a certain version of the imagick extension then the WP_Image_Editor_Imagick::test() should be updated. Thoughts?

[markoheijnen]

It wasn't that we do some kind of versioning. The problem relies in documentation and changes that are made in the imagick library. There isn't a clear documentation for that.

Testing of the library is something I work on but that is something that will happen in the next week or so.

[mpvanwinkle77]

"The problem relies in documentation and changes that are made in the imagick library. There isn't a clear documentation for that. "

Agreed, I could find very little documentation myself.

[nacin]

You can continue to call a static method non-statically, so this switch at least avoids a fatal error. If we need to do version-checking once we know more, we can.

[ryan]

In 22421:

Call Imagick::queryformats() non-statically to preserve back compat with older versions of Imagick.

Props mpvanwinkle77
fixes #22308
see #6821

[markoheijnen]

We need to revert it and use a version check since supports_mime_type() need to be static

[nacin]

​http://comments.gmane.org/gmane.comp.php.pecl.cvs/8475

I think we can use is_callable( 'Imagick', 'queryFormats' ). However, if it is not callable in static context, what do we do? We would have to instantiate a bogus Imagick object (we could easily load in a tiny file in wp-includes/images if we had to), or use a hard-coded array of the basic types (png, jpg, gif) that we know will be supported, or we can actually have test() fail and have older versions of Imagick fail.

[markoheijnen]

Check callable in test

[markoheijnen]

Something like this? I was planning to test it with at least Imagick version 2.2 but installing that seems harder then I thought.

[markoheijnen]

We can think about a version check with phpversion( 'imagick' ) but I'm unsure about that.

[nacin]

In 22549:

Revert [22421]. see #6821. see #22308. see #22419.

[nacin]

#22419 was marked as a duplicate.

[kirasong]

Replying to nacin:

​http://comments.gmane.org/gmane.comp.php.pecl.cvs/8475

I think we can use is_callable( 'Imagick', 'queryFormats' ). However, if it is not callable in static context, what do we do? We would have to instantiate a bogus Imagick object (we could easily load in a tiny file in wp-includes/images if we had to), or use a hard-coded array of the basic types (png, jpg, gif) that we know will be supported, or we can actually have test() fail and have older versions of Imagick fail.

Since it was fixed over four years ago, I'm personally fine with just requiring "new" versions of Imagick ( >= 2.2.0 ) with the is_callable check. It would definitely be preferred to avoid instantiating an object with an image just to check whether the format is supported.

@mpvanwinkle77 Which version of Imagick and provider are you currently using? Just checking to see, since we wouldn't want to miss a large base that has the older version.

[nacin]

Yep, we can probably toss the is_callable() check into test(), and just not use older versions of IM.

[kirasong]

Refreshed Marko's Patch per the revert.

[kirasong]

Agreed. To double-check, did some testing with Imagick 2.1.1 and it seems to work as expected.

Refreshed markoheijnen's previous patch above​, so that it applies cleanly after the revert.

[kirasong]

Now with comments!

[nacin]

In 22581:

Require Imagick 2.1.1 or greater, based on whether the queryFormats() method can be called statically.

props markoheijnen, DH-Shredder. fixes #22308.

[kirasong]

Looks like this is still a problem:
​http://wordpress.org/support/topic/fatal-error-with-imagemagick-and-media-editor

At the very least, we should have been running:
! is_callable( array( 'Imagick', 'queryFormats' ) ) or ! is_callable( 'Imagick::queryFormats' )

However, it looks like, per the notes, neither of these are sufficient to tell whether or not it's statically callable:
​http://www.php.net/manual/en/function.is-callable.php

A direct version check or possibly ReflectionClass are two potential solutions.
Although the safest at this point would probably be to do a version check to 2.1.1 or greater.

If no one gets to it before me, I'll compile up 2.1.0 in the morning (when I'm slightly more awake) to test this further and write up a patch.

[kirasong]

In 22308.version-check.diff​​ Add a direct version check.

Went back and checked through the code again, it does look like we need 2.2.0 or greater, indeed.

To test, installed both 2.1.1 and 2.2.0.

This patch was properly causing the editor to fall back to GD under 2.1.1 and using Imagick in 2.2.0.

If we want to get rid of more checks later, we can -- but this patch assumes better safe than sorry, in particular because no matter the version, the user can compile it with an old version of ImageMagick and get rid of some of the functions we need.

[kirasong]

I'm fine with 22308.diff​.

Tested; looks good.

[nacin]

In 22904:

Explicitly check for version 2.2.0 or higher of the Imagick PHP module, to ensure we can call queryFormats() statically. props DH-Shredder, fixes #22308.