WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#22317 closed defect (bug) (fixed)

Set min height on media UI sidebar

Reported by: apeatling Owned by:
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.5
Component: Media Keywords: has-patch
Focuses: Cc:

Description

Running r22327 on Chrome 22.0.1229.94.

Issue:

In the new media UI the sidebar "Drop files here" dropzone will overlap the search and title in the sidebar if the window height is smaller that the space needed for both.

To reproduce:

Resize the window height with the media UI showing. Anything less than 250px will cause the UI elements to overlap in the sidebar.

Solution:

Patch attached that sets min-height of 250px on .media-sidebar in order to stop the sidebar UI elements from overalapping.

The min height could also be placed on .media-modal but the entire modal will be limited then and it's still usable at heights less than 250px. The modal will also be limited if there are views without the sidebar present.

This doesn't take into account items added to the sidebar that will need more height, but I think fixing it for the base set of UI elements fine to start with.

Attachments (1)

media-min-height.diff (365 bytes) - added by apeatling 2 years ago.

Download all attachments as: .zip

Change History (3)

@apeatling2 years ago

comment:1 @SergeyBiryukov2 years ago

  • Milestone changed from Awaiting Review to 3.5

comment:2 @nacin2 years ago

  • Resolution set to fixed
  • Status changed from new to closed

The final batch of changes have made this no longer a factor.

Note: See TracTickets for help on using tickets.