Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#22318 closed defect (bug) (fixed)

Gallery preview is busted if all images are deleted

Reported by: apeatling's profile apeatling Owned by: koopersmith's profile koopersmith
Milestone: 3.5 Priority: normal
Severity: normal Version:
Component: Gallery Keywords:
Focuses: Cc:

Description

Running r22327 on Chrome 22.0.1229.94.

Issue:

Using the new media UI -- when I insert a gallery into a post, then go ahead and delete all of the images from the media library, the gallery preview is busted. It shows an empty preview graphic that can't be edited in any way.

To reproduce:

  1. Start a new post.
  2. Using the new media UI, add some images and create-insert a new gallery.
  3. Head to the media page and delete all the images that were added to the gallery
  4. Edit the post, the gallery preview is busted.

Attachments (1)

broken-gallery.png (13.2 KB) - added by MikeHansenMe 12 years ago.
screenshot of the problem

Download all attachments as: .zip

Change History (4)

#1 @SergeyBiryukov
12 years ago

  • Milestone changed from Awaiting Review to 3.5

#2 @nacin
12 years ago

  • Component changed from Media to Gallery

@MikeHansenMe
12 years ago

screenshot of the problem

#3 @koopersmith
12 years ago

  • Owner set to koopersmith
  • Resolution set to fixed
  • Status changed from new to closed

In 22567:

Media: Restore 3.4 editor behavior and remove TinyMCE views.

  • Reactivates the wpgallery and wpeditimage TinyMCE plugins. Deactivates the wpviews TinyMCE plugin.
  • Moves still-relevant logic from mce-views.js to media-upload.js and shortcode.js.
  • No longer include wp-includes/js/mce-views.js. This code will not be used in 3.5, and should be considered unstable.
  • Currently, this is the real 3.4 experience; as such, editing triggers the old modals. Changing this is the next major step.

When reassessing views, we should look over all of these tickets and anticipate these bugs accordingly.

fixes #21813, #22123, #22155, #22161, #22257, #22266, #22318, #22407, see #21390.

Note: See TracTickets for help on using tickets.