Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#22321 closed enhancement (fixed)

Update SimplePie to 1.3.1

Reported by: rmccue's profile rmccue Owned by: ryan's profile ryan
Milestone: 3.5 Priority: normal
Severity: blocker Version: 3.5
Component: External Libraries Keywords: has-patch
Focuses: Cc:

Description

SimplePie 1.3.1 is now available with a bunch of fixes.

Attachments (3)

22321.patch (25.8 KB) - added by ocean90 11 years ago.
22321.2.patch (2.9 KB) - added by ocean90 11 years ago.
22321.diff (1.5 KB) - added by nacin 11 years ago.

Download all attachments as: .zip

Change History (16)

#1 @rmccue
11 years ago

#22158 was marked as a duplicate.

#2 @rmccue
11 years ago

#22163 was marked as a duplicate.

#3 @rmccue
11 years ago

#21990 was marked as a duplicate.

#4 @ocean90
11 years ago

  • Milestone changed from Awaiting Review to 3.5
  • Type changed from defect (bug) to enhancement

#5 follow-up: @ocean90
11 years ago

  • Keywords needs-patch added; has-patch removed

#6 @westi
11 years ago

#22159 was marked as a duplicate.

#7 in reply to: ↑ 5 @rmccue
11 years ago

  • Cc nacin added
  • Keywords has-patch added; needs-patch removed

I marked this as has-patch, since it's literally just copying over the 1.3.1 release; making a .diff for it makes no sense. If you really want a patch: https://github.com/simplepie/simplepie/compare/1.3...1.3.1.diff

@ocean90
11 years ago

#8 @ryan
11 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In 22366:

Update SimplePie to 1.3.1. Props rmccue, ocean90. fixes #22321

#9 @ocean90
11 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Sorry, my patch forgot to include the new Exception.php.

@ocean90
11 years ago

#10 @ryan
11 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 22469:

Add SimplePie/Exception.php.

Props ocean90
fixes #22321

@nacin
11 years ago

#11 @nacin
11 years ago

Now that we've updated to 1.3.1, we can remove the checks added previously for 1.2 -> 1.3 compatibility. They could cause more trouble than they are worth, especially since plugins could potentially include earlier versions.

Debian will not like that create() is still getting called statically, as it'll generate E_STRICT under newer PHP versions. They actually hacked up SimplePie to add in the "static" keyword, then complained when WordPress broke. I want to note this, but this is the least of our concerns.

#12 @nacin
11 years ago

In 22599:

Remove SimplePie 1.2/1.3 compatibility code no longer needed with 1.3.1. see #22321. see #21183.

#13 @nacin
11 years ago

#22163 was marked as a duplicate.

Note: See TracTickets for help on using tickets.