WordPress.org

Make WordPress Core

Opened 18 months ago

Closed 18 months ago

Last modified 12 months ago

#22321 closed enhancement (fixed)

Update SimplePie to 1.3.1

Reported by: rmccue Owned by: ryan
Milestone: 3.5 Priority: normal
Severity: blocker Version: 3.5
Component: External Libraries Keywords: has-patch
Focuses: Cc:

Description

SimplePie 1.3.1 is now available with a bunch of fixes.

Attachments (3)

22321.patch (25.8 KB) - added by ocean90 18 months ago.
22321.2.patch (2.9 KB) - added by ocean90 18 months ago.
22321.diff (1.5 KB) - added by nacin 17 months ago.

Download all attachments as: .zip

Change History (16)

comment:1 rmccue18 months ago

#22158 was marked as a duplicate.

comment:2 rmccue18 months ago

#22163 was marked as a duplicate.

comment:3 rmccue18 months ago

#21990 was marked as a duplicate.

comment:4 ocean9018 months ago

  • Milestone changed from Awaiting Review to 3.5
  • Type changed from defect (bug) to enhancement

comment:5 follow-up: ocean9018 months ago

  • Keywords needs-patch added; has-patch removed

comment:6 westi18 months ago

#22159 was marked as a duplicate.

comment:7 in reply to: ↑ 5 rmccue18 months ago

  • Cc nacin added
  • Keywords has-patch added; needs-patch removed

I marked this as has-patch, since it's literally just copying over the 1.3.1 release; making a .diff for it makes no sense. If you really want a patch: https://github.com/simplepie/simplepie/compare/1.3...1.3.1.diff

ocean9018 months ago

comment:8 ryan18 months ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In 22366:

Update SimplePie to 1.3.1. Props rmccue, ocean90. fixes #22321

comment:9 ocean9018 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Sorry, my patch forgot to include the new Exception.php.

ocean9018 months ago

comment:10 ryan18 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 22469:

Add SimplePie/Exception.php.

Props ocean90
fixes #22321

nacin17 months ago

comment:11 nacin17 months ago

Now that we've updated to 1.3.1, we can remove the checks added previously for 1.2 -> 1.3 compatibility. They could cause more trouble than they are worth, especially since plugins could potentially include earlier versions.

Debian will not like that create() is still getting called statically, as it'll generate E_STRICT under newer PHP versions. They actually hacked up SimplePie to add in the "static" keyword, then complained when WordPress broke. I want to note this, but this is the least of our concerns.

comment:12 nacin17 months ago

In 22599:

Remove SimplePie 1.2/1.3 compatibility code no longer needed with 1.3.1. see #22321. see #21183.

comment:13 nacin12 months ago

#22163 was marked as a duplicate.

Note: See TracTickets for help on using tickets.