Make WordPress Core

Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#22359 closed defect (bug) (fixed)

Twenty Twelve: Wrap Long Text and URLs In Article Content

Reported by: philiparthurmoore Owned by: lancewillett
Priority: normal Milestone: 3.5
Component: Bundled Theme Version:
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

Long text and long URLs break the layout of Twenty Twelve in mobile view:

http://p-am.net/grabs/long_url-20121105-005907.png

Any downside in applying the same break rules we use in .widget-area .widget to .site-content article?

	word-wrap: break-word;
	-webkit-hyphens: auto;
	-moz-hyphens: auto;
	hyphens: auto;

Attachments (2)

break-long-text-in-articles.patch​ (391 bytes ) - added by philiparthurmoore 14 years ago.
Twenty Twelve: break long text in articls
22359-root.diff​ (484 bytes ) - added by DrewAPicture 14 years ago.
root-relative

Download all attachments as: .zip

Change History (11)

#1 @obenland
14 years ago

  • Keywords needs-patch added
  • Milestone Awaiting Review → 3.5

#2 in reply to: ↑ description @obenland
14 years ago

Replying to philiparthurmoore:

Any downside in applying the same break rules we use in .widget-area .widget to .site-content article?

I don't think so. Do you want to add a patch?

@philiparthurmoore
14 years ago

Twenty Twelve: break long text in articls

#3 @JustinSainton
14 years ago

  • Keywords has-patch added; needs-patch removed

#4 @georgestephanis
14 years ago

I like it -- my only hesitancy is whether the properties are better placed at the bottom of the styling block as per ​http://make.wordpress.org/core/handbook/coding-standards/css/#property-ordering

@DrewAPicture
14 years ago

root-relative

#6 @DrewAPicture
14 years ago

  • Cc xoodrew@… added

On this ​test URL, 22359-root.diff​ works as expected for me on:

iPad IOS6

  • Safari 6
  • Chrome 21

Android

  • Android browser 2.3
  • Firefox 16

#7 @lancewillett
14 years ago

  • Owner set to lancewillett
  • Resolution → fixed
  • Status new → closed

In 22576:

Twenty Twelve: wrap long text and URLs in entries. Props philiparthurmoore, fixes #22359. (Also clean up property order a bit.)

#8 @lancewillett
14 years ago

In 22577:

Twenty Twelve: revert accidental paste in r22576, see #22359.

#9 @lancewillett
14 years ago

Noting for future reference, in order for CSS hyphenation to work correctly the blog's language must be set to match the post or page content. (US English = "en-US" for example.)

See notes in ​http://wordpress.org/support/topic/strange-word-breaks-in-posts-since-11-update?replies=8#post-3569034 and ​http://www.quirksmode.org/blog/archives/2012/11/hyphenation_wor.html

Note: See TracTickets for help on using tickets.