WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 6 years ago

#22366 closed defect (bug) (fixed)

Twenty Eleven: Set non-WP images to max-width 100%

Reported by: obenland Owned by: lancewillett
Milestone: 3.6 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch commit
Focuses: Cc:

Description

If an image doesn't have a WordPress-generated class, we should be able to safely set its max width value to 100%. If the image does have a WP-generated class, we can leave it at 97.5% to accommodate border and padding rules.

Attachments (2)

22366.diff (779 bytes) - added by obenland 7 years ago.
22366.2.diff (934 bytes) - added by lancewillett 6 years ago.

Download all attachments as: .zip

Change History (11)

#1 @DrewAPicture
7 years ago

Seems reasonable enough, as long as we don't do it inline.

@obenland
7 years ago

#2 @obenland
7 years ago

  • Keywords has-patch added; needs-patch removed

#3 follow-up: @lancewillett
7 years ago

  • Milestone changed from Awaiting Review to Future Release

I think we should implement this on WP.com first, then let it soak in a while.

Recommend fixing 3.6 early.

#4 in reply to: ↑ 3 @DrewAPicture
7 years ago

  • Cc xoodrew@… added

Replying to lancewillett:

I think we should implement this on WP.com first, then let it soak in a while.

Recommend fixing 3.6 early.

Seems sensible. Let's do that.

#5 @knutsp
7 years ago

  • Cc knut@… added

#6 @lancewillett
6 years ago

  • Milestone changed from Future Release to 3.6

#7 @lancewillett
6 years ago

  • Keywords commit added

This has been working on WP.com for 2 weeks, should be safe to commit to core since no issues reported.

@lancewillett
6 years ago

#8 @lancewillett
6 years ago

Patch also adds better handling for images inside captions, fixing misalignment.

#9 @lancewillett
6 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 23654:

Twenty Eleven: set images without WordPress-generated class to 100% maximum width, and fix spacing of images within caption containers. Props obenland, fixes #22366.

Note: See TracTickets for help on using tickets.