WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#22368 closed defect (bug) (fixed)

Missing argument warning in WP_MS_Themes_List_Table

Reported by: jeremyfelt Owned by: nacin
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.5
Component: Warnings/Notices Keywords: needs-patch
Focuses: Cc:

Description

The argument for $which was removed from the bulk_actions() call in [22376], causing a complaint by WP_MS_Themes_List_Table because it still expects to see this argument and pass it on. WP_List_Table does nothing with it anyway, so we're good to remove $which...

Attachments (1)

22368.diff (498 bytes) - added by jeremyfelt 7 years ago.
Removes unnecessary argument from bulk_actions()

Download all attachments as: .zip

Change History (3)

@jeremyfelt
7 years ago

Removes unnecessary argument from bulk_actions()

#1 @scribu
7 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 3.5
  • Version set to trunk

Actually, the correct fix is to add back $which to both WP_List_Table and WP_Plugins_List_Table, since it does actually get passed in WP_List_Table::display_tablenav().

#2 @nacin
7 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 22395:

Remove methods that override but do nothing. props jeremyfelt for initial patch. fixes #22368.

Note: See TracTickets for help on using tickets.