WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#22388 closed defect (bug) (fixed)

New color picker: Instant feedback when changing the hex value

Reported by: johnbillion's profile johnbillion Owned by: mattwiebe's profile mattwiebe
Milestone: 3.5 Priority: low
Severity: normal Version: 3.5
Component: Administration Keywords: needs-patch
Focuses: Cc:

Description

Previously: #21206

When you manually change the value in the hex input field the color picker isn't updated until the hex input field loses focus. We should hook into the onkeyup event and change the picker colour immediately (or rather, when a valid hex code is present).

Not sure if this should be reported here or upstream to Iris. Reporting it here anyway.

Change History (8)

#1 @SergeyBiryukov
11 years ago

  • Type changed from enhancement to defect (bug)

#2 @helenyhou
11 years ago

  • Component changed from UI to Administration
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 3.5

#3 @nacin
11 years ago

  • Owner set to mattwiebe
  • Status changed from new to assigned

#4 @mattwiebe
11 years ago

Unsure about this. I was waiting for someone to report this. The initial trouble with doing it as you type was that color error-handling was at that time not very good. Error-handling is pretty good now, but this may still introduce side effects. I will test and report back.

#5 @nacin
11 years ago

Waiting until they hit six characters would probably prevent most side effects.

#6 @nacin
11 years ago

  • Priority changed from normal to low

#8 @nacin
11 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 22732:

Color picker: Instant feedback when typing a color. Strengthens alt + arrows for moving around the palette. props mattwiebe. fixes #22475. fixes #22388.

Note: See TracTickets for help on using tickets.