Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#22395 closed enhancement (fixed)

Single accents in the Title field should be removed from URLs, just like apostrophes

Reported by: anonymized_7658014's profile anonymized_7658014 Owned by: nacin's profile nacin
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.4.2
Component: Formatting Keywords: has-patch 3.6-early
Focuses: Cc:

Description

This is about the Title and URL fields in the post edit screen.

Currently, single accents are treated as valid entities for URLs:

TITLE: Als wär´s ein Stück von mir
=> URL: http://domain.tld/als-war´-s-ein-stuck-von-mir
=> URL: http://domain.tld/als-war%C2%B4-s-ein-stuck-von-mir

Note how the accent is inaccurately used as an apostrophe here. Sadly, many users do that.
Because it is a single accent, the same behavior as with an apostrophe would save the URL here:

TITLE: Als wär´s ein Stück von mir (U+00B4 Acute Accent)
-OR-
TITLE: Als wär`s ein Stück von mir (U+0060 Grave Accent)
-OR-
TITLE: Als wär's ein Stück von mir (U+0027 Apostrophe)
-OR-
TITLE: Als wär’s ein Stück von mir (U+2018 Left Single Quotation)
-OR-
TITLE: Als wär‘s ein Stück von mir (U+2019 Right Single Quotation)

-SHOULD ALL BE REMOVED FROM URLS LIKE APOSTROPHES-

=> URL: http://domain.tld/als-wars-ein-stuck-von-mir

Disclaimer: Is there a need for non-western languages to keep accents and/or single quotations in URLs?

Attachments (1)

22395.patch (652 bytes) - added by SergeyBiryukov 12 years ago.

Download all attachments as: .zip

Change History (5)

#1 @rmccue
12 years ago

  • Keywords has-patch added; needs-patch removed

#2 @SergeyBiryukov
12 years ago

  • Component changed from Editor to Formatting
  • Keywords 3.6-early added
  • Milestone changed from Awaiting Review to Future Release

22395.patch adds more acute accents to sanitize_title_with_dashes().

Unit test: [UT1122]

#3 @SergeyBiryukov
12 years ago

  • Milestone changed from Future Release to 3.6

#4 @nacin
12 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 23176:

Remove additional acute accents from permalink slugs via sanitize_title_with_dashes(). props SergeyBiryukov. fixes #22395.

Note: See TracTickets for help on using tickets.