WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#22399 closed defect (bug) (fixed)

"Insert link" modal window does no longer show recent items in existing content list

Reported by: TobiasBg Owned by: nacin
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.5
Component: General Keywords:
Focuses: Cc:

Description

Go to add a new post/page.
Click the "link" button in the editor toolbar.
Open the "Or link to existing content" list.

Problem: The initial list of existing content ist empty. No recent pages/posts are shown.
Only when typing a search word, items are shown.

In 3.4.2, the initial list shows the recent posts/pages just fine.

Chrome DevTools showed that the "wp-link-ajax" AJAX request is not fired when the list is first shown. It is only fired when searching.

Change History (6)

comment:1 @nacin3 years ago

  • Milestone changed from Awaiting Review to 3.5

wpLink.refresh, which is bound to wpdialogrefresh (as in, this._trigger('refresh') in the wpdialog widget), isn't firing. Could be a jQuery UI thing.

comment:2 @duck_3 years ago

The event being fired is dialogrefresh (not the missing wp prefix). Presumably a behaviour change in jQuery UI has stopped the event prefix override.

comment:3 @nacin3 years ago

Tracked this down to jQuery 1.9.1 — http://bugs.jqueryui.com/ticket/8724. Reverting https://github.com/jquery/jquery-ui/commit/848ab485839b6dd26f2b6c6680141d95cab32ceb fixes it. We don't actually use the event prefix override, but some code that went back in to fix people who were (as it is going away) seemed to break something for us. UI's scott.gonzalez is looking into it.

Version 0, edited 3 years ago by nacin (next)

comment:4 @nacin3 years ago

In 22513:

Define a custom event prefix in the wpdialog jQuery UI widget to work around a jQuery UI 1.9.1 regression. see #22399.

comment:5 @TobiasBg3 years ago

[22513] fixes it for me. Nice! :-)

comment:6 @nacin3 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 22514:

WordPress dialog jQuery UI widget:

  • Link to the upstream bug report.
  • No need to specify the default value for an option.
  • Use the new _super() UI method to open the dialog, avoiding a direct reference to the parent.
  • Fix typo in comment.
  • Use public isOpen() method rather than a private property.

props scott.gonzalez.
fixes #22399.

Note: See TracTickets for help on using tickets.