Bookmarks/links Illegal string offset.

[pross]

Warning: Illegal string offset 'categorize' in /home/pross/public_html/wp-includes/bookmark-template.php on line 213

Added quick patch.

[SergeyBiryukov]

Introduced in [22426].

[bpetty]

Ah, yes, this is correct. We only tested with the default theme which never calls wp_list_bookmarks() with no arguments. This means $args was always an array instead of the default empty string.

This would happen though if wp_list_bookmarks() was called from other themes without any arguments.

[bpetty]

I wonder if it would be better to change the $args parameter default to array() instead. Is there a policy against using non-scalar default arguments?

[nacin]

Replying to bpetty:

I wonder if it would be better to change the $args parameter default to array() instead. Is there a policy against using non-scalar default arguments?

Nope. But I'm fine with patch.patch​ as it prevents further issues, like a plugin passing a scalar value in.

[nacin]

In 22565:

Avoid notices with [22426]. props pross. fixes #22420.