Trunk Dashboard Throwing Fatal Error

[miqrogroove]

Just installed trunk 3.5-beta2-22546 in debug mode. The dashboard Incoming Links widget displayed this:

Fatal error: Call to undefined method DOMElement::getLineNo() in wp-includes/SimplePie/Locator.php on line 280

Checked logs and found no other entries.

After navigating away and returning to the dashboard, error repeats.

[SergeyBiryukov]

The method is only available since PHP 5.3.0.

There's a method_exists() check in two places, but not in that one.

Related: ​https://github.com/simplepie/simplepie/issues/223

[georgestephanis]

Yup, that line is

if ($this->base_location < $link->getLineNo())

Probably should be

if ($this->base_location < ( method_exists( $link, 'getLineNo' ) ? $link->getLineNo() : 1 ) )

[georgestephanis]

rmccue added a fix a month ago on the github repo --

​https://github.com/simplepie/simplepie/commit/75baa9651ee04c8c7d57702a8d5f1b7b6eb58605

[SergeyBiryukov]

The mentioned fix

[SergeyBiryukov]

Looks like the fix was only committed to the master branch and didn't get included in SimplePie 1.3.1 ([22366]).

[nacin]

In 22555:

SimplePie: Ensure the DOMNode::getLineNo() method exists. props rmccue. fixes #22425.

[rmccue]

Replying to SergeyBiryukov:

Looks like the fix was only committed to the master branch and didn't get included in SimplePie 1.3.1 ([22366]).

Damn it, I'll backport that ASAP. Thanks.