WordPress.org

Make WordPress Core

Opened 17 months ago

Closed 17 months ago

Last modified 17 months ago

#22425 closed defect (bug) (fixed)

Trunk Dashboard Throwing Fatal Error

Reported by: miqrogroove Owned by: nacin
Milestone: 3.5 Priority: normal
Severity: major Version: 3.5
Component: External Libraries Keywords: has-patch
Focuses: Cc:

Description

Just installed trunk 3.5-beta2-22546 in debug mode. The dashboard Incoming Links widget displayed this:

Fatal error: Call to undefined method DOMElement::getLineNo() in wp-includes/SimplePie/Locator.php on line 280

Checked logs and found no other entries.

After navigating away and returning to the dashboard, error repeats.

Attachments (1)

22425.patch (692 bytes) - added by SergeyBiryukov 17 months ago.
The mentioned fix

Download all attachments as: .zip

Change History (8)

comment:1 nacin17 months ago

  • Component changed from General to External Libraries
  • Milestone changed from Awaiting Review to 3.5

comment:2 SergeyBiryukov17 months ago

The method is only available since PHP 5.3.0.

There's a method_exists() check in two places, but not in that one.

Related: https://github.com/simplepie/simplepie/issues/223

comment:3 georgestephanis17 months ago

Yup, that line is

if ($this->base_location < $link->getLineNo())

Probably should be

if ($this->base_location < ( method_exists( $link, 'getLineNo' ) ? $link->getLineNo() : 1 ) )

SergeyBiryukov17 months ago

The mentioned fix

comment:5 follow-up: SergeyBiryukov17 months ago

  • Keywords has-patch added

Looks like the fix was only committed to the master branch and didn't get included in SimplePie 1.3.1 ([22366]).

comment:6 nacin17 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 22555:

SimplePie: Ensure the DOMNode::getLineNo() method exists. props rmccue. fixes #22425.

comment:7 in reply to: ↑ 5 rmccue17 months ago

Replying to SergeyBiryukov:

Looks like the fix was only committed to the master branch and didn't get included in SimplePie 1.3.1 ([22366]).

Damn it, I'll backport that ASAP. Thanks.

Note: See TracTickets for help on using tickets.