WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #22435, comment 33


Ignore:
Timestamp:
10/25/2013 03:15:45 PM (6 years ago)
Author:
nbachiyski
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #22435, comment 33

    initial v1  
    1 In working out how to handle taxonomy loops that can cause a WSOD, I encountered some problems with the approach given here. For example, the try/catch stuff in ```wp_export()``` returns things, but we never do anything with it, which means that the error handling is basically moot. Also, ```WP_Export_XML_Over_HTTP::write()``` just spews headers and whatever output there is (even if it's empty because of a silent error), which makes error handling problematic. The forthcoming patch includes some tax loop handling but also rejiggers a couple of things to provide better error handling (I hope). I'm not sure it's 100% of the way there, but I thought I'd submit for consideration. It's a diff of the diff, to isolate the changes I'm proposing.
     1In working out how to handle taxonomy loops that can cause a WSOD, I encountered some problems with the approach given here. For example, the try/catch stuff in `wp_export()` returns things, but we never do anything with it, which means that the error handling is basically moot. Also, `WP_Export_XML_Over_HTTP::write()` just spews headers and whatever output there is (even if it's empty because of a silent error), which makes error handling problematic. The forthcoming patch includes some tax loop handling but also rejiggers a couple of things to provide better error handling (I hope). I'm not sure it's 100% of the way there, but I thought I'd submit for consideration. It's a diff of the diff, to isolate the changes I'm proposing.