Make WordPress Core

Opened 12 years ago

Closed 11 years ago

Last modified 11 years ago

#22442 closed enhancement (wontfix)

Allow target="_blank" to plugins description from File Header

Reported by: themedios's profile themedios Owned by:
Milestone: Priority: normal
Severity: minor Version: 3.4.2
Component: Plugins Keywords: has-patch
Focuses: Cc:

Description

It is noticed that target="_blank" does not work in the plugins description on the Installed Plugins page. If a user clicks on a link then it opens in the same tab.

Attached is the patch which allows to add the target attribute to the a element in plugins description

Attachments (1)

22442.diff (559 bytes) - added by themedios 12 years ago.
Diff file for adding target blank in plugins description

Download all attachments as: .zip

Change History (12)

@themedios
12 years ago

Diff file for adding target blank in plugins description

#1 @themedios
12 years ago

  • Version 3.4.2 deleted

#2 @themedios
12 years ago

  • Version set to trunk

#3 follow-up: @SergeyBiryukov
12 years ago

  • Version changed from trunk to 3.4.2

Version field indicates when the enhancement was initially suggested.

#4 in reply to: ↑ 3 @themedios
12 years ago

Replying to SergeyBiryukov:

Version field indicates when the enhancement was initially suggested.

Thanks for the info Sergey. Actually, the diff file that I had made was after checking out the latest copy from the trunk. Hence, I was in the impression that the version field is when the enhancement shall be released.

Anyways, Thanks again!

#5 @toscho
12 years ago

  • Cc info@… added

Please … no. Going back is much easier than closing a new forced tab. It would introduce an inconsistency without any benefit. Let’s keep the interface predictable. The user should decide how and where a link opens.

#6 @sabreuse
12 years ago

-1 aside from the fact that it's generally a nasty trick to surprise the user, forcing new tabs/windows is awful for accessibility.

#7 @themedios
12 years ago

Basically, this is only a matter of allowing the attribute. The plugin author will decide whether he wants to have the user to open any external links in a new window or not.

While developing a plugin recently, I noticed that I had put up a link to an external page in the description which has information on how to use the plugin. I gave it target _blank so that the user will be able to view the instructions and perform the steps on the dashboard side by side. But ofcourse this did not work. So the only option a user will have is to ctrl+click the link to open in a new tab or go back and forth.

Hence, just wanted to put this as a consideration.

Last edited 12 years ago by themedios (previous) (diff)

#8 @kovshenin
12 years ago

-1 I don't like websites opening new tabs or windows, even search engines stopped doing that. Users are also getting smarter and holding the Cmd/Ctrl or Shift keys when they want a new tab or window. Also, on touch devices it's easier to swipe back than it is to close a new tab or window.

#9 @SergeyBiryukov
12 years ago

  • Keywords close added

#10 @c3mdigital
11 years ago

  • Keywords 2nd-opinion close removed
  • Resolution set to wontfix
  • Status changed from new to closed

Users should always be able to control where new links open.

#11 @SergeyBiryukov
11 years ago

  • Milestone Awaiting Review deleted
Note: See TracTickets for help on using tickets.