Make WordPress Core

Opened 3 years ago

Last modified 3 years ago

#22446 closed defect (bug)

Insert Media modal: IE 7, 8, and 9 issues — at Version 14

Reported by: SergeyBiryukov Owned by: ocean90
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.5
Component: Media Keywords: audit has-patch commit
Focuses: Cc:

Description (last modified by ocean90)

  1. The vertical line on the left is displayed in IE 9, but not in IE 8 (see 22446.ie8.png, 22446.ie9.png). [22610]
  1. "Drop files anywhere to upload" shouldn't be displayed in IE 7/8/9, as it doesn't support drag-and-drop (at least it doesn't on wp-admin/media-new.php). [22609]
  1. IE 7 needs some attention for the gallery view, see 22446.ie7_gallery.png
  1. IE 7 doesn't display the selected images (22446.ie7_selected_images.png) and in IE 9 you can see the second line (22446.ie9_selected_images.png)
  1. In IE 7 and IE 8 you can't see which image is currently selected (blue border is missing), see 22446.ie8_selected_image.png
  1. In IE 7 Embed from URL doesn't work. Nothing happens after inserting an URL.
  1. When uploading an image in IE 7 a pop up comes up which wants to download admin-ajax.php. The file includes the JSON respond.
  1. IE 8: Upload an image, switch to media library, try to change the filter dropdown. It will open the upload dialog.
  1. IE 9: Non-image thumbnails are quite off, see 22446.ie9.selected-music.png​ or 22446.ie9.selected-music2.png​

Change History (23)

@SergeyBiryukov3 years ago

@SergeyBiryukov3 years ago

@ocean903 years ago

comment:1 @ocean903 years ago

  • Description modified (diff)
  • Summary changed from Insert Media modal looks odd in IE 8 to Insert Media modal: IE 7, 8, and 9 issues

comment:2 @SergeyBiryukov3 years ago

  • Description modified (diff)

comment:3 @ocean903 years ago

  • Description modified (diff)

comment:4 @ocean903 years ago

  • Keywords needs-patch added
  • Owner set to ocean90
  • Status changed from new to accepted

comment:5 @nacin3 years ago

  • Keywords audit added

@ocean903 years ago

comment:6 @ocean903 years ago

The missing borders around the images are a result of the use of box-shadow, which IE 7 and 8 doesn't support. I think we should try to use real CSS borders here.

comment:7 @koopersmith3 years ago

In 22609:

Media: Only display "Drop files" text when the browser supports drag and drop. see #22446, #21390.

comment:8 @koopersmith3 years ago

In 22610:

Media: Add an explicit border to menus to show a divider in older browsers. see #22446, #21390.

comment:9 @ocean903 years ago

  • Description modified (diff)

comment:10 @koopersmith3 years ago

In 22611:

Media: The zIndex arms race.

Adjusts zIndexes to be not-as-absurd as before, in the process moving the modal below the plupload flash shims (which do not have customizable zIndexes or classes, sadly).

fixes #22441, see #22446, #21390.

comment:11 @koopersmith3 years ago

In 22612:

Media: zIndex peace was only temporary.

Revert [22611] in favor of using plupload's container setting. Turns out, plupload's flash shim is forced to the exact same index as the admin bar, so balancing the two is better solved by nesting the shim.

see #22441, #22446, #21390.

comment:12 @ocean903 years ago

  • Description modified (diff)

comment:13 @ocean903 years ago

  • Description modified (diff)

comment:14 @ocean903 years ago

  • Description modified (diff)
Note: See TracTickets for help on using tickets.