Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#22449 closed defect (bug) (fixed)

Spinner causes row to grow in height

Reported by: nacin's profile nacin Owned by: lessbloat's profile lessbloat
Milestone: 3.5 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch commit
Focuses: Cc:

Description

When replying to a comment, the spinner that gets shown briefly is a bit taller than the row (when you add in padding, line height, etc), causing the row to grow by a pixel or two. It then shrinks again when the spinner is hidden. Related to switching from visibility: visible/hidden to display: none in #21456.

Attachments (3)

22449.diff (432 bytes) - added by lessbloat 12 years ago.
22449.2.diff (475 bytes) - added by SergeyBiryukov 12 years ago.
22449.3.diff (618 bytes) - added by SergeyBiryukov 12 years ago.

Download all attachments as: .zip

Change History (11)

#1 @nacin
12 years ago

  • Owner set to lessbloat
  • Status changed from new to assigned

@lessbloat
12 years ago

#2 @lessbloat
12 years ago

22449.diff​ should do the trick.

#3 follow-up: @lessbloat
12 years ago

Well, now it loses a few pixels after the spinner goes away. I'll take another stab at it.

#4 in reply to: ↑ 3 @lessbloat
12 years ago

Replying to lessbloat:

Well, now it loses a few pixels after the spinner goes away. I'll take another stab at it.

Never mind. My local install was causing me problems, which threw a false alarm. 22449.diff​ should do it.

#5 @SergeyBiryukov
12 years ago

  • Keywords has-patch added

Tested, looks good.

22449.2.diff does the same without duplicating the additional rules.

#6 @nacin
12 years ago

  • Keywords commit added

Because it's only two shared rules, 22449.diff is a bit easier to grasp.

#7 @SergeyBiryukov
12 years ago

My only (minor) concern with 22449.diff is that it leaves
inline-edit-save .spinner by itself in the /* reply to comments */ block, where it doesn't actually belong.

22449.3.diff moves it to the Inline Editing block.

#8 @nacin
12 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 22627:

Fix the padding of the waiting spinner when replying to comments. props lessbloat, SergeyBiryukov. fixes #22449.

Note: See TracTickets for help on using tickets.