WordPress.org

Make WordPress Core

#22453 closed defect (bug) (fixed)

3.5 RTL audit

Reported by: nacin Owned by: ocean90
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.5
Component: RTL Keywords: audit has-patch commit
Focuses: Cc:

Description

Audit RTL in 3.5. Look for breakage and inconsistencies, especially with new features: media, the color picker, etc.


Notes on how you can help auditing:

While you can set $text_direction to 'rtl' in wp-config.php, this is largely imperfect as English strings don't necessarily flip correctly, which can be tough when an english string has HTML elements. (We saw this, for example, with page numbering above/below the list tables.)

I built a 3.5-beta3 download package for he_IL: http://he.wordpress.org/release-archive/he_IL/wordpress-3.5-beta3-he_IL.zip. If you download it and want to integrate into an existing test install, The key is copying over wp-content/languages/* and then setting WPLANG in wp-config.php to 'he_IL'.

Attachments (12)

22453.welcome-screen.patch (3.3 KB) - added by ocean90 20 months ago.
22453.media-view.patch (6.1 KB) - added by ocean90 20 months ago.
20469.add-media.diff (723 bytes) - added by SergeyBiryukov 20 months ago.
22453.image-editor.patch (641 bytes) - added by maor 20 months ago.
22453.image-editor-theme-filter.patch (1.6 KB) - added by ocean90 20 months ago.
22453.patch (5.3 KB) - added by ocean90 20 months ago.
22453.admin-bar-webkit.patch (394 bytes) - added by ocean90 20 months ago.
22453.media-view.2.patch (1.9 KB) - added by ocean90 20 months ago.
RTL-media.png (213.5 KB) - added by ramiy 20 months ago.
22453.2.patch (3.0 KB) - added by ocean90 20 months ago.
22615.3b.patch (3.2 KB) - added by ocean90 20 months ago.
22453.wp-colorpicker.patch (4.2 KB) - added by ocean90 20 months ago.

Download all attachments as: .zip

Change History (47)

comment:1 ocean9020 months ago

  • Cc ocean90 added

comment:2 in reply to: ↑ description maor20 months ago

  • Cc maorhaz@… added

If you download it and want to integrate into an existing test install, The key is copying over wp-content/languages/* and then setting WPLANG in wp-config.php to 'he_IL'.

Thanks, nacin. I'll be testing that.

comment:3 follow-up: maor20 months ago

@nacin, I've unpacked the attached ZIP archive and installed WordPress normally. When I first logged in, the dashboard was all flipped over as if it didn't have the RTL stylesheet included. http://i.imgur.com/mT2pK.png

However, when I enabled on SCRIPT_DEBUG it all got back to normal.

Other than that there are minor CSS issues. Especially with the new button styles. http://i.imgur.com/7FtPg.png
Also, I haven't noticed anything exceptional about the pagination area over and below list tables. This is how it looks:

http://i.imgur.com/uLGpz.png

In general it's looking pretty good.

ocean9020 months ago

comment:4 follow-up: ocean9020 months ago

Attached 22453.welcome-screen.patch for the Welcome Screen and 22453.media-view.patch for the media modal.

comment:5 koopersmith20 months ago

In 22604:

Media: RTL styles for the media modal. props ocean90. see #22453, #21390.

comment:6 in reply to: ↑ 3 ramiy20 months ago

Replying to maor:

... the dashboard was all flipped over as if it didn't have the RTL stylesheet included.
However, when I enabled on SCRIPT_DEBUG it all got back to normal.

I confirm that.

Adding define('SCRIPT_DEBUG', true); to wp-config.php fixed the problem.


Replying to Nasin:


Other RTL issuies:

comment:8 ramiy20 months ago

  • Cc r_a_m_i@… added

comment:9 ramiy20 months ago

And checkout this related ticket #16834. I reported this issue almost 2 years ago.

comment:10 DrewAPicture20 months ago

  • Cc xoodrew@… added

comment:11 SergeyBiryukov20 months ago

20469.add-media.diff fixes "Add Media" button (http://i.imgur.com/7FtPg.png in comment:3).

padding-left: 10px (rather than 0 or auto) comes from default button styles.

Last edited 20 months ago by SergeyBiryukov (previous) (diff)

comment:12 in reply to: ↑ 4 maor20 months ago

Replying to ocean90:

Attached 22453.welcome-screen.patch for the Welcome Screen and 22453.media-view.patch for the media modal.

RE the Welcome Panel patch. I noticed padding was added to the welcome panel column's wrapper, and it makes them look a little weird. http://i.imgur.com/yjDgL.png. Instead there should be no padding on that element, exactly the way it is in the LTR version.

Done some testings (see below) and figured it looks much better without the padding on the right http://i.imgur.com/9u2rR.png.

.welcome-panel .welcome-panel-column-container {
	padding: 0 0 0 25px;
}
Version 0, edited 20 months ago by maor (next)

comment:13 maor20 months ago

Attached 22453.image-editor.patch for the attachment editor screen. Fixes the "Edit Image" button. (http://i.imgur.com/jHoTh.png in comment:6).

maor20 months ago

comment:15 helenyhou20 months ago

Welcome panel stuff still going on at #21368, since it was reopened, including RTL. Hopefully we'll close that off soon to reduce confusion.

comment:16 azaozz20 months ago

In [22638]:

Welcome screen: clean up the css, improve the html, add RTL styles, props helenyhou TobiasBg ocean90, fixes #21368, see #22453

comment:17 ocean9020 months ago

  • Keywords has-patch commit added
  • Version set to trunk

22453.image-editor-theme-filter.patch extends the patch from maor. It removes unneeded lines and improves the image edit buttons.

20469.add-media.diff and 22453.image-editor-theme-filter.patch should be committed.

ocean9020 months ago

comment:18 ocean9020 months ago

22453.patch combines 20469.add-media.diff and 22453.image-editor-theme-filter.patch​. The patch also fixes the spinners, the featured image button and the edit slug box.

comment:19 azaozz20 months ago

In 22640:

RTL fixes and improvements: add-media, image-editor, the spinners, the featured image button, some css cleanup, props ocean90, maor, SergeyBiryukov, ramiy, see #22453

comment:20 azaozz20 months ago

In 22641:

RTL: fix styling of Skip To links, see #22453

comment:21 ocean9020 months ago

22453.admin-bar-webkit.patch fixes an issue in Webkit, see [18934].

In [19080] the fix was added to the RTL style with the transform to border-right. Since the bug exits only on the left side the RTL change reverts the originally fix. The lines should be removed from the RTL style again.

comment:22 azaozz20 months ago

In 22643:

RTL: remove unneeded toolbar border-right, props ocean90, see #22453

comment:23 nacin20 months ago

  • Keywords has-patch commit removed

Lots of patches and commits here. Anything left uncommitted or unpatched? If not, it'd be cool to finish off #16834 too as it is the only other RTL issue open on Trac.

comment:25 ocean9020 months ago

  • Keywords commit added

comment:26 nacin20 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 22720:

RTL media-views fixes. props ocean90. fixes #22453.

ramiy20 months ago

comment:27 ramiy20 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:28 helenyhou20 months ago

  • Keywords needs-patch added; has-patch commit removed

Media modal.

http://core.trac.wordpress.org/raw-attachment/ticket/22453/RTL-media.png

comment:29 ocean9020 months ago

  • Owner changed from nacin to ocean90
  • Status changed from reopened to accepted

ocean9020 months ago

comment:30 ocean9020 months ago

  • Keywords has-patch added; needs-patch removed

ocean9020 months ago

comment:31 koopersmith20 months ago

  • Keywords commit added

comment:32 ocean9020 months ago

22453.wp-colorpicker.patch adds RTL support for the colorpicker. (And includes a small clean up.)

comment:34 ryan20 months ago

In 22947:

RTL fixes for media and color picker.

Props ocean90
see #22453

comment:35 ocean9020 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed
Note: See TracTickets for help on using tickets.