WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #22456, comment 15


Ignore:
Timestamp:
11/20/12 17:32:53 (2 years ago)
Author:
TobiasBg
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #22456, comment 15

    initial v1  
    22> 22456.4.patch uses CSS to hide check all checkboxes. 
    33 
    4 Using the existing {{{.hide-if-no-js}}} has the advantage that it adds "meaning" or "reasoning" as to why the checkboxes are hidden - directly to the checkboxes' markup. Using some extra CSS for this instead might make the markup shorter, but opens the question: "Why do we actually have and keep {{{.hide-if-no-js}}} then?" 
     4Using the existing {{{.hide-if-no-js}}} class has the advantage that it adds "meaning" or "reasoning" as to why the checkboxes are hidden - directly to the checkboxes' markup. Using some extra CSS for this instead might make the markup shorter, but opens the question: "Why do we actually have and keep {{{.hide-if-no-js}}} then?" 
    55The new CSS adds what {{{.hide-if-no-js}}} wants to prevent: Extra and hard to maintain CSS code.