Remove header text 'restore' button left over from Farbtastic

[DrewAPicture]

In custom-header.php, the old Farbtastic color picker relied on a separate button to reset back to the theme default text color. We don't need it anymore.

Patch attached.

[helenyhou]

Man, that text was confusing to begin with. I was looking at this patch wondering since when you could restore header text and what it would even restore to, and what restoring it had to do with the color mod.

[SergeyBiryukov]

Replying to helenyhou:

Man, that text was confusing to begin with.

Related: #17605

[nacin]

Could this still be needed for no JS?

[DrewAPicture]

Replying to nacin:

Could this still be needed for no JS?

It's my understanding this is in no way connected to the new Iris color picker. That's not to say it couldn't be hooked up to it, but in its current form, it was part of Farbtastic.

Edit: I should add that the no-js fallback should just be a textbox, as it was pre-3.4, so I'm not sure this button would be useful in any current context.

[helenyhou]

I guess it does help with no JS, since it's an actual form submit, but the fallback to an input is there as well.

[nacin]

Replying to helenyhou:

I guess it does help with no JS, since it's an actual form submit, but the fallback to an input is there as well.

Right, but does the input allow for falling back (resetting) to the default color?

[helenyhou]

Replying to nacin:

Right, but does the input allow for falling back (resetting) to the default color?

Nope, unless you knew what it was and enter it yourself. Wonder if we can make a generic fallback for resetting to default. Too late?

[DrewAPicture]

Replying to helenyhou:

Nope, unless you knew what it was and enter it yourself. Wonder if we can make a generic fallback for resetting to default. Too late?

What about just falling back to a text input and outputting a label next to it with the default color?

Header Text Color		#[	] Default: #000000

[DrewAPicture]

+ no-js label

[DrewAPicture]

An approach similar to comment:9 is in 22461.2.diff​ and looks like this:

Also note the vertical alignments seem generally off in Chrome.

[lessbloat]

In 22461.3.diff​ just moved the default text up next to the field, and added class="description":

[DrewAPicture]

Looks good to me. Also noticed there's an extra space after the hex code in the printf we can remove.

[DrewAPicture]

errant space

[DrewAPicture]

22461.4.diff​ just removed the errant space in the string.

[DrewAPicture]

removes resettext $_POST bits

[helenyhou]

22461.5.diff​ is looking good to me. Thanks for remembering to remove the $_POST part :)

[helenyhou]

Also, opened #22509 for a generic default color fallback in no-JS.

[nacin]

In 22695:

Custom Header: Remove Farbtastic-era "Reset Text Color" button. Show default color when JS is disabled. props DrewAPicture. fixes #22461.