WordPress.org

Make WordPress Core

#22467 closed defect (bug) (fixed)

3.5 general IE audit (excluding media)

Reported by: lessbloat Owned by: nacin
Milestone: 3.5 Priority: normal
Severity: normal Version:
Component: Administration Keywords: audit has-patch commit
Focuses: Cc:

Description

Sweep of IE 7, 8, 9 functionality for 3.5.

#22446, and #22441 re related media specific IE tickets.

Attachments (9)

22467.ie8-arial.png (13.1 KB) - added by SergeyBiryukov 17 months ago.
22467.ie8-georgia.png (13.5 KB) - added by SergeyBiryukov 17 months ago.
22467.ie7-dashboard.png (97.6 KB) - added by SergeyBiryukov 17 months ago.
22467.diff (719 bytes) - added by lessbloat 17 months ago.
22467.2.diff (410 bytes) - added by lessbloat 17 months ago.
22467.ff-action-links.png (89.6 KB) - added by SergeyBiryukov 17 months ago.
22467.ie8-action-links.png (92.5 KB) - added by SergeyBiryukov 17 months ago.
22467.action-links.patch (1.6 KB) - added by SergeyBiryukov 17 months ago.
22467.ie8-action-links-after.png (92.5 KB) - added by SergeyBiryukov 17 months ago.

Download all attachments as: .zip

Change History (29)

comment:1 nacin17 months ago

  • Component changed from Accessibility to Administration
  • Milestone changed from Awaiting Review to 3.5

comment:2 follow-up: lessbloat17 months ago

Items I noticed:

IE8

  • Customizer: JS error preventing site preview from showing
  • Welcome screen: needs some help at smaller resolutions

IE7

  • Welcome screen formatting is way off

comment:3 follow-up: miqrogroove17 months ago

IE 8

  1. Start a new post.
  2. Click the Add Media button.
  3. Screen Says "Drop files anywhere to upload."
  4. Drag a file into the window.
  5. Alert dialog says, "Are you sure you want to navigate away from this page?"

lessbloat: Customizer worksforme.

comment:4 ocean9017 months ago

miqrogroove, that's #22441/#22446.

comment:5 in reply to: ↑ 2 ocean9017 months ago

Replying to lessbloat:

IE7

  • Welcome screen formatting is way off

#19687

comment:6 in reply to: ↑ 3 ; follow-up: lessbloat17 months ago

Replying to miqrogroove:

IE 8

lessbloat: Customizer worksforme.

Can someone else please confirm? I'm getting a JS error, 'response' is being returned as undefined line 366 on customize-controls.js. May just be my setup...

Last edited 17 months ago by lessbloat (previous) (diff)

comment:7 in reply to: ↑ 6 ; follow-up: SergeyBiryukov17 months ago

Replying to lessbloat:

Can someone else please confirm?

Customizer works in IE 8 for me. However, I've found an odd bug:

  1. Open "Site Title & Tagline".
  2. Toggle "Display Header Text" checkbox.
  3. The font in section headers briefly changes to Arial: 22467.ie8-arial.png.
  4. Move your mouse to highlight another section.
  5. The font changes back to Georgia: 22467.ie8-georgia.png.

Perhaps a result of #21283?

Last edited 17 months ago by SergeyBiryukov (previous) (diff)

comment:8 follow-up: SergeyBiryukov17 months ago

Some RTL issues in IE 7:

comment:9 in reply to: ↑ 7 ; follow-up: lessbloat17 months ago

Replying to SergeyBiryukov:

Replying to lessbloat:

Can someone else please confirm?

Customizer works in IE 8 for me. However, I've found an odd bug:

  1. Open "Site Title & Tagline".
  2. Toggle "Display Header Text" checkbox.
  3. The font in section headers briefly changes to Arial: 22467.ie8-arial.png.
  4. Move your mouse to highlight another section.
  5. The font changes back to Georgia: 22467.ie8-georgia.png.

Perhaps a result of #21283?

I can't seem to replicate this. Mind checking it again?

lessbloat17 months ago

comment:10 in reply to: ↑ 8 lessbloat17 months ago

Replying to SergeyBiryukov:

Some RTL issues in IE 7:

Both should be fixed in 22467.diff​.

comment:11 follow-up: nacin17 months ago

Should that text-indent: -1000em; change only be applied to ie-rtl.css?

comment:12 in reply to: ↑ 9 SergeyBiryukov17 months ago

Replying to lessbloat:

I can't seem to replicate this. Mind checking it again?

comment:7 turned out to be unrelated to #21283. I can only reproduce it with Twenty Twelve when Open Sans is enabled.

lessbloat17 months ago

comment:13 in reply to: ↑ 11 lessbloat17 months ago

Replying to nacin:

Should that text-indent: -1000em; change only be applied to ie-rtl.css?

Good call. See 22467.2.diff​.

comment:15 ocean9017 months ago

  • Keywords has-patch commit added

22467.2.diff​

comment:16 nacin17 months ago

In 22721:

IE RTL fixes for .screen-reader-text. props lessbloat. see #22467.

comment:17 nacin17 months ago

  • Keywords has-patch commit removed

Anything else?

comment:18 SergeyBiryukov17 months ago

[21067] prevented delete theme link from bumping against theme action links, however there's another issue in IE 7/8: the link wraps to the next line with longer strings (22467.ie8-action-links.png vs. 22467.ff-action-links.png).

22467.action-links.patch fixes that. Screenshot: 22467.ie8-action-links-after.png.

comment:19 ocean9017 months ago

  • Keywords has-patch commit added

22467.action-links.patch and we're done here.

comment:20 nacin17 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 22799:

Fix action link styling in IE7 and IE8. props SergeyBiryukov. fixes #22467.

Note: See TracTickets for help on using tickets.