WordPress.org

Make WordPress Core

#22468 closed defect (bug) (fixed)

Twenty Twelve: arrow in reply text renders poorly

Reported by: miqrogroove Owned by: lancewillett
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.5
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

The "Reply" links in the Twenty Twelve theme all look like they are followed by some random garbage characters. They look more like arrows in Twenty Eleven, and they don't appear at all in my own theme. I'll attach some screen shots.

Attachments (7)

twenty-twelve-chrome.png (13.9 KB) - added by miqrogroove 18 months ago.
WinXP Screen Shots
twenty-twelve-firefox.png (18.8 KB) - added by miqrogroove 18 months ago.
twenty-twelve-ie8.png (13.3 KB) - added by miqrogroove 18 months ago.
twenty-twelve-opera.png (13.5 KB) - added by miqrogroove 18 months ago.
twenty-eleven-chrome.png (13.3 KB) - added by miqrogroove 18 months ago.
At least it looks like an arrow here.
image.jpg (231.0 KB) - added by miqrogroove 18 months ago.
Looks weird on iPad.
miqro-22468.diff (800 bytes) - added by miqrogroove 17 months ago.

Download all attachments as: .zip

Change History (23)

miqrogroove18 months ago

WinXP Screen Shots

comment:1 nacin18 months ago

Are you using Windows XP font smoothing? Or rather, why aren't you? (And, why XP?)

comment:2 miqrogroove18 months ago

The &darr code can be found in the twentytwelve_comment() callback where it uses comment_reply_link(). Currently, http://core.trac.wordpress.org/browser/trunk/wp-content/themes/twentytwelve/functions.php#L311

I am using XP because I like it, and my computer is ancient. Font smoothing makes the text blurry and annoys me.

miqrogroove18 months ago

At least it looks like an arrow here.

miqrogroove18 months ago

Looks weird on iPad.

comment:3 kovshenin18 months ago

  • Cc kovshenin added

comment:4 lancewillett17 months ago

I vote "wontfix" on this, works fine in the vast majority of browsers and OS versions.

comment:5 helenyhou17 months ago

I think it's more that the underline combined with the down arrow, which descends below the baseline, looks a little weird, even in more modern combinations.

Last edited 17 months ago by helenyhou (previous) (diff)

comment:6 miqrogroove17 months ago

helenhou are there other browsers/OS examples you could screen shot?

comment:7 helenyhou17 months ago

I'm on OSX. It looks like it does in your iPad screenshot, except not HiDPI.

comment:8 miqrogroove17 months ago

On OSX does it look the same in all browsers? Maybe 1 or 2 screen shots would help.

comment:9 lancewillett17 months ago

  • Cc drewstrojny added

@drewstrojny What do you think about removing the underline or arrow here?

comment:10 drewstrojny17 months ago

I'd say remove the arrow if it's causing issues. The basic link works just fine.

comment:11 miqrogroove17 months ago

Just a thought: comment_reply_link() offers an "after" argument. Move the arrow after the link, as seen here on Trac?

miqrogroove17 months ago

comment:12 miqrogroove17 months ago

Patch attached for clarity. Uncertain if arrow requires translation though.

comment:13 lancewillett17 months ago

  • Milestone changed from Awaiting Review to 3.5

Nope, since it's a down arrow it doesn't need to be translated. (Left or right would for RTL languages.)

comment:14 miqrogroove17 months ago

  • Keywords has-patch added

That should do it then.

comment:15 lancewillett17 months ago

  • Summary changed from Twenty Twelve's &darr Renders Poorly to Twenty Twelve: arrow in reply text renders poorly

comment:16 lancewillett17 months ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 22614:

Twenty Twelve: improve arrow display in comment reply text, props miqrogroove. Also consistent styles for edit link to match reply link in color and size. Closes #22468.

Note: See TracTickets for help on using tickets.