Post-formats radiogroup on custom post types and pages will not update in 3.5 Beta 3

[itworx]

The post-formats are being saved, but the radiogroup will not show selected format after publishing, but stays checked at Standard post-format.

Works only on posts.

[c3mdigital]

I can confirm this.

Enable post format support and add for pages.

add_theme_support( 'post-formats', array( 'aside', 'gallery' ) );
add_post_type_support( 'page', 'post-formats' );

get_theme_support( 'post-formats' );
returns the correct array of post formats.

get_post_format() always returns false on page or custom post types.

Create new page and change post format from normal and publish or save draft. On refresh the checked value goes back to normal.

[SergeyBiryukov]

Broken in [21981], which added ! is_object_in_taxonomy() check to get_the_terms():
​http://core.trac.wordpress.org/browser/trunk/wp-includes/category-template.php?rev=22412#L1065

[SergeyBiryukov]

22473.patch​ reverts a part of [21981].

[SergeyBiryukov]

Related: #20438

[nacin]

I was under the impression that register_taxonomy_for_object_type() was also necessary for proper post format support with custom post types. I mentioned in #20438 (which Sergey linked to, thanks) that we decided that back in 3.1.

Of course, if something that happened to work previously now works, we should fix.

[SergeyBiryukov]

22473.patch​ caused a warning in wp_list_pluck() after saving changes in Quick Edit.

22473.2.patch​ fixes that.

[nacin]

Yeah, 22473.2.patch​ looks good to me. get_the_terms() is too much of a generic-use function for us to get away with a formal taxonomy check.

[ryan]

​[UT1141]

[ryan]

In 22722:

Don't bail from get_the_terms() if the post type is not registed for the taxonomy. This can break back compat when add_post_type_support( 'page', 'post-formats' ) is called but register_taxonomy_for_object_type( 'postr_-format', 'page' ) is not.

Props SergeyBiryukov
fixes #22473