Make WordPress Core

Opened 12 years ago

Closed 10 years ago

#22478 closed defect (bug) (fixed)

Remove $force argument from WP_Object_Cache::delete()

Reported by: ryan's profile ryan Owned by: wonderboymusic's profile wonderboymusic
Milestone: 3.9 Priority: normal
Severity: normal Version: 2.0
Component: Cache API Keywords:
Focuses: Cc:


This was introduced way back in [3086] and hasn't been needed for years.

Attachments (1)

22478.patch (940 bytes) - added by SergeyBiryukov 10 years ago.

Download all attachments as: .zip

Change History (9)

#1 @nacin
10 years ago

  • Milestone changed from Future Release to 3.9

Sounds good. This was for internal-use-only, I don't think _deprecated_argument() is needed, but let's put a comment somewhere just so we know we'd have to be careful if we ever want to add a third argument here later.

#2 @SergeyBiryukov
10 years ago

Could we just rename it to $deprecated?

#3 @wonderboymusic
10 years ago

I am open to any and all suggestions - do whatever you think works.

#4 @wonderboymusic
10 years ago

also, [27064] didn't post here.

#5 @kovshenin
10 years ago

  • Resolution set to fixed
  • Status changed from new to closed
  • Version changed from 3.4.2 to 2.0

Fixed in r27064.

#6 @SergeyBiryukov
10 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

22478.patch would probably be more obvious and consistent with how we generally handle deprecated arguments.

I'm fine with [27064] too, so feel free to re-close if we want to remove the argument completely here.

#7 @wonderboymusic
10 years ago

I have no preference - change however you want

#8 @wonderboymusic
10 years ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from reopened to closed

In 27162:

Rather than removing the 3rd argument in WP_Object_Cache::delete(), mark it as $deprecated.

See [27064].
Props SergeyBiryukov.
Fixes #22478.

Note: See TracTickets for help on using tickets.