Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#22486 closed defect (bug) (fixed)

PHP warning when creating a new site as part of a network

Reported by: jkudish Owned by: westi
Milestone: 3.5 Priority: high
Severity: major Version: 3.5
Component: Multisite Keywords: has-patch commit
Focuses: Cc:

Description (last modified by jkudish)

I get the following error when I create a new site as part of a network running an up-to-date checkout of trunk.

Notice: Undefined variable: s in .../wp/wp-admin/network/site-new.php on line 88

My setup is a bit particular but I am fairly positive it has nothing to do with the bug. Here it goes anyway:

  • locally hosted, using MAMP Pro, mapped to a .dev domain using my hosts file
  • subdomain setup for multisite
  • WordPress is in a subfolder on the domain, in a folder named 'wp'
  • The wp-content folder has been moved to '/content'

The double quotes are causing the $ to be executed as variables by the PHP parser instead of being interpreted as strings to replace by sprintf
Patch attached that fixes the issue.

Attachments (3)

22486.diff (1.1 KB) - added by jkudish 3 years ago.
22486.2.diff (1.1 KB) - added by jkudish 3 years ago.
22486.3.diff (1.1 KB) - added by SergeyBiryukov 3 years ago.

Download all attachments as: .zip

Change History (11)

3 years ago

#1 @jkudish
3 years ago

  • Description modified (diff)

#2 @nacin
3 years ago

Broken in [22272].

#3 @nacin
3 years ago

[22273] [22271] [22270] all look good.

#4 @nacin
3 years ago

  • Keywords needs-patch added; has-patch removed
  • Owner set to westi
  • Status changed from new to assigned

The attached patch breaks the string; it is no longer translatable. We'll need to A) escape them, B) remove them, or C) add manual line breaks to the string. B or C are probably most friendly to the translators.

3 years ago

#5 @jkudish
3 years ago

In 22486.2.diff:

How's this approach? It splits the string up into 3 which may or may not be ideal for translators.

#6 @SergeyBiryukov
3 years ago

  • Keywords has-patch added; needs-patch removed

In ms-functions.php we use actual line breaks for such strings:

22486.3.diff does the same for consistency.

#7 @ocean90
3 years ago

  • Keywords commit added

#8 @nacin
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 22664:

Add manual new lines to a string, as double quotes with \n is not optimal due to sprintf-parsing reasons. props SergeyBiryukov, fixes #22486. see #22260.

Note: See TracTickets for help on using tickets.