Make WordPress Core

Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#22490 closed defect (bug) (fixed)

New buttons: Disabled state in iOS

Reported by: johnbillion Owned by: koopersmith
Priority: normal Milestone: 3.5
Component: UI Version: 3.5
Severity: minor Keywords: has-patch needs-testing
Cc: Focuses:

Description

Disabled buttons retain their pill-like rounded corners in iOS.

Attachments (3)

ios-disabled-buttons.png​ (5.3 KB ) - added by johnbillion 14 years ago.
22490.diff​ (403 bytes ) - added by johnbillion 14 years ago.
Patch
ios-buttons-after.png​ (5.0 KB ) - added by johnbillion 14 years ago.
After

Download all attachments as: .zip

Change History (10)

@johnbillion
14 years ago

Patch

@johnbillion
14 years ago

After

#1 @johnbillion
14 years ago

  • Keywords has-patch added

Patch.

Note that if you're using Chrome on iOS (and maybe Safari too), its caching is very aggressive. Clearing the cache from the Settings menu doesn't clear all files in the cache, such as some CSS files. It's very odd. I ended up bumping the version number in wp-includes/version.php to get the updated buttons.css to load.

#2 follow-up: @azaozz
14 years ago

  • Keywords needs-testing added

Don't see the pill shapes in Safari/iOS6. Removing the internal -webkit-appearance: push-button; might have other implications.

#3 in reply to: ↑ 2 @johnbillion
14 years ago

Replying to azaozz:

Don't see the pill shapes in Safari/iOS6.

Looks like it's an iOS 5 issue then. Confirmed in Chrome and Safari on iOS 5.

Removing the internal -webkit-appearance: push-button; might have other implications.

Are there implications other than appearance? We have rules in place for border, background, font, padding, etc etc.

#4 @SergeyBiryukov
14 years ago

  • Type enhancement → defect (bug)

#5 @nacin
14 years ago

Best I can tell, it does not appear to have any implications beyond appearance.

#6 @koopersmith
14 years ago

  • Owner set to koopersmith
  • Resolution → fixed
  • Status new → closed

In 22704:

Buttons: Ensure correct disabled submit button state in iOS. props johnbillion, fixes #22490.

#7 @ocean90
14 years ago

  • Milestone Awaiting Review → 3.5
Note: See TracTickets for help on using tickets.