Make WordPress Core

Opened 12 years ago

Closed 8 years ago

#22498 closed defect (bug) (worksforme)

Disabling Header Text should not reset Header Text Color to default

Reported by: drewapicture's profile DrewAPicture Owned by:
Milestone: Priority: low
Severity: minor Version: 3.4.2
Component: Customize Keywords: ux-feedback has-patch
Focuses: administration Cc:

Description

In Appearance > Header, if you uncheck the 'Show header text with your image' option and Save, the Text Color option is reset to whatever the default is.

With JS enabled, the Text Color option is hidden when the checkbox is unchecked, but in no-js both options are displayed all the time. It's odd to set a header text color and uncheck the option only to have it reset your choice to the default.

Related: #22461

Attachments (2)

22498.patch (675 bytes) - added by ocean90 10 years ago.
22498.diff (1.6 KB) - added by kovshenin 10 years ago.

Download all attachments as: .zip

Change History (9)

#1 @DrewAPicture
10 years ago

  • Keywords ux-feedback added

OK, so this actually still valid. After a small amount of testing, I noticed it's also impossible to update the header text color from the default while the 'Show header text with your image' option is disabled in no-js. Seems like weird UX.

@ocean90
10 years ago

#2 @ocean90
10 years ago

  • Focuses administration added
  • Keywords has-patch commit added
  • Milestone changed from Awaiting Review to 4.0
  • Priority changed from normal to low
  • Severity changed from normal to minor

22498.patch hides tr.displaying-header-text if display_header_text() is false. Sure, that requires two clicks for no-js but has a better UX in my eyes.

@kovshenin
10 years ago

#3 @kovshenin
10 years ago

This is tricky, because both options are actually one single theme mod called header_textcolor, which if set to "blank" hides the text. We don't save the previous value when updating to "blank", so there's no value to restore from. The behavior in the customizer seems okay unless you refresh after hiding the text. If you refresh then it's all the same reset to default.

To address the reset issue in this ticket, we can probably store the actual color in a different theme mod, like 22498.diff.

This ticket was mentioned in IRC in #wordpress-dev by celloexpressions. View the logs.


10 years ago

#5 @ocean90
10 years ago

  • Keywords commit removed
  • Milestone changed from 4.0 to Future Release

#6 @DrewAPicture
9 years ago

@ocean90: Any idea if this is still an outstanding problem? If not, feel free to close it.

#7 @DrewAPicture
8 years ago

  • Milestone Future Release deleted
  • Resolution set to worksforme
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.