Disabling Header Text should not reset Header Text Color to default

[DrewAPicture]

In Appearance > Header, if you uncheck the 'Show header text with your image' option and Save, the Text Color option is reset to whatever the default is.

With JS enabled, the Text Color option is hidden when the checkbox is unchecked, but in no-js both options are displayed all the time. It's odd to set a header text color and uncheck the option only to have it reset your choice to the default.

Related: #22461

[DrewAPicture]

OK, so this actually still valid. After a small amount of testing, I noticed it's also impossible to update the header text color from the default while the 'Show header text with your image' option is disabled in no-js. Seems like weird UX.

[ocean90]

22498.patch​ hides tr.displaying-header-text if display_header_text() is false. Sure, that requires two clicks for no-js but has a better UX in my eyes.

[kovshenin]

This is tricky, because both options are actually one single theme mod called header_textcolor, which if set to "blank" hides the text. We don't save the previous value when updating to "blank", so there's no value to restore from. The behavior in the customizer seems okay unless you refresh after hiding the text. If you refresh then it's all the same reset to default.

To address the reset issue in this ticket, we can probably store the actual color in a different theme mod, like 22498.diff​.

[DrewAPicture]

@ocean90: Any idea if this is still an outstanding problem? If not, feel free to close it.