WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#22500 closed task (blessed) (fixed)

Don't ship Twenty Ten in 3.5

Reported by: nacin Owned by: nacin
Milestone: 3.5 Priority: normal
Severity: normal Version:
Component: Themes Keywords: audit
Focuses: Cc:
PR Number:

Description

Twenty Ten has served us well. However, we need to draw the line somewhere on how many themes we should ship with each core release, and I think it should be two.

When Twenty Thirteen ships with 3.6 or 3.7, Twenty Eleven should be dropped.

Here's what I recently wrote on the theme-reviewers mailing list:

The plan is to continue to maintain the default themes, from Twenty Ten on.

It's actually quite simple to do, so I don't expect this plan to change in the foreseeable future. Once the default themes each hit 1.0, we don't touch the code much anyway, as we want to avoid breaking child themes (even with regards to styling). So we're mostly just working out bug fixes as they get reported; and opting in to new core features as we go. Adding support for newer core features is an obvious thing to do, because it allows us to eat our own dog food. We can't expect someone else to update a theme to use a new feature, especially in a backwards compatible way, if we can't do it ourselves. But none of the themes are getting rewritten, or anything like that.

Anyway, you can continue to file tickets under the "Bundled Theme" component on Trac. This will be the case even after Twenty Ten becomes "unbundled," which I think might be for 3.5. (From there, we'll continue with a policy of always shipping two themes.)

So what I think we should do is actually just exclude it from the zips, keeping it in SVN trunk for the time being. That makes it easy to maintain for now, prevents us from needing to transfer around SVN history, or work Twenty Ten out of the 3.4 branch, Twenty Eleven out of the 3.5 branch, Twenty Twelve out of the 3.9 branch, etc (whichever branch it last shipped with). We just leave them all in /trunk and keep it out of the build process.

Change History (7)

#1 @nacin
7 years ago

I have code written that modifies the release script to remove bundled themes over time, assuming we sign off on this.

#2 @nacin
7 years ago

  • Keywords audit added
  • Owner set to nacin
  • Status changed from new to accepted

#3 @bradparbs
7 years ago

  • Cc brad@… added

Good plan!

#4 @kovshenin
7 years ago

  • Cc kovshenin added

#6 @lancewillett
7 years ago

  • Cc lancewillett added

+1

#7 @nacin
7 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

Approved during the November 21 IRC meeting. The packaging aspects for this has been handled — the wordpress-3.5.zip will have only two themes. (Note for now, we'll need to manually exclude Twenty Eleven come Twenty Thirteen, etc., so someone, um, remind me...)

Note: See TracTickets for help on using tickets.