Make WordPress Core

Opened 12 years ago

Closed 8 years ago

#22509 closed defect (bug) (wontfix)

No-JS fallback for default color in color picker

Reported by: helen's profile helen Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Administration Keywords: needs-patch
Focuses: ui Cc:

Description

The no-JS fallback for the color picker is just a plain input. Since the color picker implementation now includes the ability to reset to a specified default, it seems to make sense to include a no-JS fallback for the default, even just as a little bit of hidden descriptive text.

See #22461 for discussion stemming from the custom header screen.

Attachments (1)

22509.diff (820 bytes) - added by DrewAPicture 12 years ago.

Download all attachments as: .zip

Change History (9)

@DrewAPicture
12 years ago

#1 @DrewAPicture
12 years ago

  • Cc xoodrew@… added
  • Keywords has-patch added

Patch. Looks like this:

http://f.cl.ly/items/3e1l1D2K1y341P2e3r0C/Screen%20Shot%202012-11-19%20at%2012.44.42%20PM.png

#2 @lessbloat
12 years ago

+1 to 22509.diff​. Looks good.

#3 @helenyhou
12 years ago

Thinking we can do it even more generically for color picker in general, not just specific to the screen. Don't have an actual practical solution in mind, just thinking about the possibilities.

#4 @helen
12 years ago

  • Reporter changed from helenyhou to helen

#5 @helen
12 years ago

  • Keywords ui-focus added

#6 @chriscct7
9 years ago

  • Keywords needs-patch ux-feedback added; has-patch removed

Its not an ideal solution, because old browsers won't support it, but in HTML5 there is a color input type we could use

#7 @helen
9 years ago

  • Keywords ux-feedback removed

I don't love the HTML5 color input implementation - I was mostly thinking of a <span class="hide-if-js">#default-value</span> solution wherever we output the field ourselves, including now the customizer control.

#8 @helen
8 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

I've decided this is no longer relevant, and also I clearly spaced when I was thinking about a no-JS thing being inside the customizer :)

Note: See TracTickets for help on using tickets.